Refactor + improve diagnostics for &mut T/T mismatch inside Option/Result
#114150
Conversation
rustbot
added
S-waiting-on-review
| span, def_path | ||
| } | ||
| } else if let Some(expected_ty_expr) = expected_ty_expr | ||
| // FIXME: suggest changes to both expressions to convert both to |
There was a problem hiding this comment.
Possibly we could have a multipart suggestion to add .as_ref() to one side and .as_deref() to the other, but that somewhat duplicates an existing diagnostic that adds .as_deref(), so not sure of the best solution here
| use crate::errors::{ | ||
| AddReturnTypeSuggestion, ExpectedReturnTypeLabel, SuggestBoxing, SuggestConvertViaMethod, | ||
| }; |
There was a problem hiding this comment.
Any particular reason to remove those imports?
There was a problem hiding this comment.
We should be using errors:: in the code instead of importing them.
There was a problem hiding this comment.
iirc the main reason being preventing merge conflicts as diagnostic imports tend to get changed a lot
|
@bors r+ (I was sure I did this already but apparently not?) |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f9f674f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 653.409s -> 651.072s (-0.36%) |
Follow up to #114052. This also makes the diagnostics structured + translatable.
r? @WaffleLapkin