Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc book: make more pleasant to search #114878

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

tshepang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2023
@GuillaumeGomez
Copy link
Member

r? rust-lang/compiler

@rustbot rustbot assigned davidtwco and unassigned GuillaumeGomez Aug 16, 2023
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes mdBook's search require all words be found in matches, so searching "foo bar" finds text containing "foo bar", not text containing "foo" and text containing "bar". Seems reasonable to me.

@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 16, 2023

📌 Commit 50ca860 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 16, 2023
…idtwco

rustc book: make more pleasant to search
@tshepang
Copy link
Member Author

yeah, I should have explained... this makes it work like common web search engines

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 16, 2023
…idtwco

rustc book: make more pleasant to search
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#113115 (we are migrating to askama)
 - rust-lang#114784 (Improve `invalid_reference_casting` lint)
 - rust-lang#114822 (Improve code readability by moving fmt args directly into the string)
 - rust-lang#114878 (rustc book: make more pleasant to search)
 - rust-lang#114899 (Add missing Clone/Debug impls to SMIR Trait related tys)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 82b92ad into rust-lang:master Aug 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 16, 2023
@tshepang tshepang deleted the tshepang-patch-1-1 branch August 17, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants