Correct and expand documentation of handle_alloc_error and set_alloc_error_hook.
#115007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oc_error_hook`. Add the following facts: * `handle_alloc_error` may panic instead of aborting. * What happens if a hook returns rather than diverging. * A hook may panic. (This was already demonstrated in an example, but not stated in prose.) * A hook must be sound to call — it cannot assume that it is only called by the runtime, since its function pointer can be retrieved by safe code.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#114924 (coverage: Tidy up `run-coverage` tests in several small ways) - rust-lang#114927 (CI: add more debug logging to Docker caching) - rust-lang#114957 (tests: Fix tests for LoongArch64) - rust-lang#115007 (Correct and expand documentation of `handle_alloc_error` and `set_alloc_error_hook`.) - rust-lang#115098 (rust-gdbgui: remove excessive quotes) - rust-lang#115111 (compile rust-anaylzer with `x check` if it's enabled) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this change is to remove the false claim that
handle_alloc_erroralways aborts; instead, code should be prepared forhandle_alloc_errorto possibly unwind, and be sound under that condition.I saw other opportunities for improvement, so I have added all the following information:
handle_alloc_errormay panic instead of aborting. (Fixes Clarify thathandle_alloc_errormay unwind #114898)I've checked these statements against the source code of
allocandstd, but there may be nuances I haven't caught, so a careful review is welcome.