Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc: Add unstable --no-html-source flag #115135

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

GuillaumeGomez
Copy link
Member

Fixes #115060.

This is the equivalent of #![doc(no_html_source)] but on the command-line. It disables the generation of the source pages (and of the links pointing to them as well).

The motivation behind this is to enable to reduce documentation size when generating it in some locations without enforcing this to end users or adding a new feature to enable/disable the crate attribute.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 23, 2023
@rust-log-analyzer

This comment has been minimized.

@notriddle
Copy link
Contributor

Sure, makes sense.

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2023

📌 Commit 73ccfc5 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2023
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#114696 (Fix a pthread_t handle leak rust-lang#114610)
 - rust-lang#115102 (Improve note for the `invalid_reference_casting` lint)
 - rust-lang#115103 (Disable bootstrap rustc version check)
 - rust-lang#115106 (ArchiveWrapper: handle LLVM API update)
 - rust-lang#115109 (Skip ExpandYamlAnchors when the config is missing)
 - rust-lang#115135 (Rustdoc: Add unstable --no-html-source flag)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5cbc00f into rust-lang:master Aug 23, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
@GuillaumeGomez GuillaumeGomez deleted the no-html-source-flag branch August 23, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a rustdoc commandline parameter to disable generation of source code pages
5 participants