Update Clippy #115183
Merged
Update Clippy #115183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a piece of mutable state. Follow up to rust-lang#114578.
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#114194 (Inline trivial (noop) flush calls) - rust-lang#114257 (Avoid using `ptr::Unique` in `LinkedList` code) - rust-lang#114359 ([library/std] Replace condv while loop with `cvar.wait_while`.) - rust-lang#114402 (Fix documentation of impl From<Vec<T>> for Rc<[T]>) - rust-lang#114715 (Revert clippy lint [`filter_map_bool_then`]) r? `@ghost` `@rustbot` modify labels: rollup
…y created somewhere in the test folder
Update ui test crate This update also removes the `//`@run-rustfix`` flag, and just runs rustfix on all tests. This means I had to opt out of running rustfix on ~100 tests, but it also allowed me to remove the rustfix coverage check entirely, as it is now effectively builtin. changelog: update ui-test crate to 0.13 (automatically runs rustfix on all tests)
Fix SPEEDTEST instructions and output * `--nocapture` hasn't been needed anymore since forever (even before `ui_test`) * the result was dividing by 1000 instead of the number of test runs, giving bogus (but still useful for the purpose) timing results. changelog: fix SPEEDTEST instructions and output
The comment was likely obsolete.
Now that generics and lifetimes are output as expected, the lint should be applicable.
refactor: rename variable chore: reorder test: update naming for msrv
…p1995 Do not bless by default in ui tests This restores the default behaviour to check the `.stderr`, it was changed in rust-lang#11239 to bless by default in `cargo test` (unless in github actions), but check by default in `cargo uitest` which is fairly confusing It also meant `cargo uitest -F internal` no longer worked `--bless` prevents the use of `Args::test` but we can look at reintegrating with that after `@oli-obk's` vacation r? `@flip1995` changelog: none
…lexendoo [`manual_retain`]: add lint case for `binary_heap` Closes rust-lang#9059 This PR adds changes to perform linting on the `binary_heap` as well, under the [manual_retain rule](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_retain). changelog: [manual_retain]: update for lint `binary_heap`
…nd() Key idea: ``` // before iter.cloned().filter(|x| unimplemented!() ) // after iter.filter(|&x| unimplemented!() ).cloned() // before iter.cloned().filter( foo ) // after iter.filter(|&x| foo(x) ).cloned() ```
[iter_overeager_cloned]: detect `.cloned().filter()` and `.cloned().find()` changelog: [`iter_overeager_cloned`]: detect `.cloned().filter()` and `.cloned().find()` Key idea: ``` // before iter.cloned().filter(|x| unimplemented!() ) // after iter.filter(|&x| unimplemented!() ).cloned() // before iter.cloned().filter( foo ) // after // notice `iter` must be `Iterator<Item= &T>` (callee of `cloned()`) // so the parameter in the closure of `filter` must be `&&T` // so the deref is safe iter.filter(|&x| foo(x) ).cloned() ```
|
And here is the error output: https://github.com/rust-lang/rust/actions/runs/5968131837/job/16191280755?pr=115183#step:24:3115 |
|
r=me but looks like we have CI issues |
|
Looks like I messed up something with aux file paths: https://github.com/oli-obk/ui_test/blob/a18ef37bf3dcccf5a1a631eddd55759fe0b89617/src/lib.rs#L479 |
|
@bors r=Manishearth,oli-obk |
bors
added
S-waiting-on-bors
|
@bors p=1 |
|
☀️ Test successful - checks-actions |
This was referenced Aug 29, 2023
Merged
This was referenced Aug 29, 2023
|
Finished benchmarking commit (b2515fa): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.431s -> 631.565s (0.18%) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2023
[`Clippy`] Use symbols intended for `arithmetic_side_effects` rust-lang#115177 added the symbols for `arithmetic_side_effects` and now this PR actually uses them to prevent an eventual removal. All because rust-lang#115183 was recently merged and next Clippy update will probably take some time to happen. Fixes rust-lang/rust-clippy#11392
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 7, 2023
…-obk
Update Clippy
r? `@oli-obk` Assigning you, because something broke with ui_test:
```
tests/ui/crashes/ice-7272.rs FAILED:
command: "<unknown>"
A bug in `ui_test` occurred: called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
full stderr:
```
(and that 103 times)
Thought I would ping you, before starting to investigate. Maybe you know what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk Assigning you, because something broke with ui_test:
(and that 103 times)
Thought I would ping you, before starting to investigate. Maybe you know what's going on.