Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special cases that are no longer needed due to #112606 #115197

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Remove special cases that are no longer needed due to #112606 #115197

merged 1 commit into from
Aug 26, 2023

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Aug 25, 2023 •
edited by compiler-errors
Loading

cc #112606

@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 25, 2023
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit 5e76e20 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2023
@bors
Auto merge of rust-lang#115246 - matthiaskrgr:rollup-zdiw9gt, r=matth…
7646ece 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115197 (Remove special cases that are no longer needed due to rust-lang#112606)
 - rust-lang#115210 (Make `rustc_on_unimplemented` std-agnostic for `alloc::rc`)
 - rust-lang#115237 (Fixup sparc-unknown-none-elf table spacing)
 - rust-lang#115244 (Migrate GUI colors test to original CSS color format)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8e35b20 into rust-lang:master Aug 26, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tbu- @rustbot @joshtriplett @bors