Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rustc_abi debugging attribute #115226

Merged
merged 1 commit into from
Aug 27, 2023
Merged

add rustc_abi debugging attribute #115226

merged 1 commit into from
Aug 27, 2023

Conversation

RalfJung
Copy link
Member

This is the call ABI equivalent of rustc_layout(debug).

Fixes #115168
r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2023
@RalfJung RalfJung force-pushed the debug-abi branch 2 times, most recently from 9b4e93f to 9bd2fa1 Compare August 25, 2023 21:06
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me ideally changing that Instance::resolve call to a call to Instance::mono, unless you want a specific review from bjorn3

@RalfJung RalfJung force-pushed the debug-abi branch 2 times, most recently from a3479f3 to b24936f Compare August 26, 2023 06:07
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@RalfJung RalfJung force-pushed the debug-abi branch 2 times, most recently from 4b72dd0 to 1c4a454 Compare August 26, 2023 09:26
@RalfJung
Copy link
Member Author

r? @compiler-errors
@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Aug 26, 2023

📌 Commit 1c4a454b2ad1099cb49be4f5480ae796e69339bb has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned bjorn3 Aug 26, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Testing commit 1c4a454b2ad1099cb49be4f5480ae796e69339bb with merge aea5ceb8d460ecf6cf84521ad3a0fabb46ef46ef...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 26, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2023
@RalfJung
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Aug 27, 2023

📌 Commit abe2148 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2023
@bors
Copy link
Contributor

bors commented Aug 27, 2023

⌛ Testing commit abe2148 with merge 0fe46ee...

@bors
Copy link
Contributor

bors commented Aug 27, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 0fe46ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2023
@bors bors merged commit 0fe46ee into rust-lang:master Aug 27, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 27, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0fe46ee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [1.0%, 5.9%] 8
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-3.8%, -0.9%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.43s -> 631.815s (0.06%)
Artifact size: 316.11 MiB -> 316.06 MiB (-0.01%)

@RalfJung RalfJung deleted the debug-abi branch August 29, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ABI information in rustc_layout(debug)
7 participants