Some SMIR Const cleanups

[oli-obk]

Only e1def3bd41b021ce87a5d639b10cdf4a7df1d0b5 is new logic, everywhere else I just used the implementations that y'all had already written.

r? @spastorino

cc @ouz-a

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @spastorino (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

[spastorino]

@bors r+

[oli-obk]

@bors rollup

[bors]

📌 Commit 0b3d80ebeb81ffcbce1b40dae1792a225c4a4002 has been approved by spastorino

It is now in the queue for this repository.

[bors]

☔ The latest upstream changes (presumably #115354) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

@bors r=spastorino

[bors]

📌 Commit 92cfd20 has been approved by spastorino

It is now in the queue for this repository.

[bors]

⌛ Testing commit 92cfd20 with merge 2c468b77e105e57c622e80d9a91d92a9c37275a5...

[bors]

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 2c468b77e105e57c622e80d9a91d92a9c37275a5 to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[oli-obk]

@bors retry

[oli-obk]

@bors r-

[oli-obk]

@bors r=spastorino

[bors]

📌 Commit 92cfd20 has been approved by spastorino

It is now in the queue for this repository.

[bors]

⌛ Testing commit 92cfd20 with merge 2bd8131...

[bors]

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 2bd8131 to master...

[rust-timer]

Finished benchmarking commit (2c468b77e105e57c622e80d9a91d92a9c37275a5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.7%, 1.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.9%, -0.4%]	4
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	-0.4%	[-1.9%, 1.3%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.235s -> 630.698s (-0.09%)
Artifact size: 316.59 MiB -> 316.53 MiB (-0.02%)

[rust-timer]

Finished benchmarking commit (2bd8131): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.8%, 1.7%]	3
Regressions ❌ (secondary)	1.8%	[1.2%, 2.1%]	3
Improvements ✅ (primary)	-1.0%	[-1.5%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-1.5%, 1.7%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.299s -> 632.412s (0.02%)
Artifact size: 316.46 MiB -> 316.49 MiB (0.01%)