optimize and cleanup bootstrap source

[onur-ozkan]

I suggest reviewing this commit by commit.

[rustbot]

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

[onur-ozkan]

@rustbot author

[rustbot]

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

[onur-ozkan]

Architectural changes will be done in a separate PR to avoid complicating the review process for this PR.

@rustbot ready

[albertlarsan68]

@bors r+ rollup=iffy (changes things in the build machinery)

[bors]

📌 Commit 5eaecac has been approved by albertlarsan68

It is now in the queue for this repository.

[onur-ozkan]

I introduced dylib_util.rs to reduce compilation time by avoiding linking of libbootstrap and all it's dependencies when compiling the auxiliary helper executables.

Whill check it.

If you are deleting the changelog, maybe also delete the changelog-seen key in config.toml? This key and the changelog was used when we made significant changes to the defaults of bootstrap affecting everyone's workflows.

It's still useful, but can make more sense if we find better name and use the PR links instead of versions(similar to llvm).

@bors r-

[onur-ozkan]

Changelog related commits will be cherry-picked to another PR that I am planning to refactor this changelog-seen key as it's not really functioning as expected(e.g., we did many changes on the build flows, but never updated the key or the Changelog files).

Until then, @rustbot blocked

[onur-ozkan]

Changelog related commits have been moved to #115898.

No changes since the r+ from @albertlarsan68, just reduced some commits. @bors r=albertlarsan68

[bors]

📌 Commit 9971008 has been approved by albertlarsan68

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9971008 with merge c3b58c1...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

💔 Test failed - checks-actions

[albertlarsan68]

@bors retry (seems like a builder crashed, no logs available)

[bors]

⌛ Testing commit 9971008 with merge cdd182c...

[bors]

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing cdd182c to master...

[rust-timer]

Finished benchmarking commit (cdd182c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	3.6%	[3.1%, 4.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.641s -> 636.485s (0.13%)
Artifact size: 318.45 MiB -> 318.24 MiB (-0.06%)