-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support {disable,enable}-patch-binaries-for-nix
in configure.py
#115544
support {disable,enable}-patch-binaries-for-nix
in configure.py
#115544
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with the typo fixed
Signed-off-by: onur-ozkan <[email protected]>
9d7398f
to
d454cab
Compare
@bors r=albertlarsan68 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b402182): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 627.066s -> 627.159s (0.01%) |
Provide the control of
patch-binaries-for-nix
flag from configure.py without requiring manual editing.It's useful when:
rust/src/bootstrap/bootstrap.py
Lines 661 to 667 in bf1e3f3