Add context to let: Ty = loop { break };
#116187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't accounting for the case where `break` was immediately within the `loop` block.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#115934 (Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things) - rust-lang#116149 (Anonymize binders for `refining_impl_trait` check) - rust-lang#116178 (Add test for `const async fn`) - rust-lang#116187 (Add context to `let: Ty = loop { break };`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2023
Rollup merge of rust-lang#116187 - estebank:small-tweak, r=compiler-errors Add context to `let: Ty = loop { break };` We weren't accounting for the case where `break` was immediately within the `loop` block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't accounting for the case where
breakwas immediately within theloopblock.