add test for const-eval error in dead code during monomorphization #116444

RalfJung · 2023-10-05T08:03:02Z

No description provided.

rustbot · 2023-10-05T08:03:09Z

(rustbot has picked a reviewer for you, use r? to override)

RalfJung · 2023-10-05T08:04:06Z

tests/ui/consts/const-eval/unused-broken-const-late.stderr

+  --> $DIR/unused-broken-const-late.rs:18:5
+   |
+LL |     no_codegen::<i32>();
+   |     ^^^^^^^^^^^^^^^^^^^


@oli-obk ideally the error would point not only here, but also at line 14 where the constant syntactically appears. Any idea why it doesn't do that?

hmm... good point ^^ probably an oversight in the mono time error handler

RalfJung · 2023-10-07T23:57:08Z

In fact whether the span at no_codegen::<i32>(); is shown seems to depend on the optimization level?

oli-obk · 2023-10-10T13:59:19Z

@bors r+ rollup

bors · 2023-10-10T13:59:21Z

📌 Commit 5e1b0cb has been approved by oli-obk

It is now in the queue for this repository.

…i-obk add test for const-eval error in dead code during monomorphization

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#109422 (rustdoc-search: add impl disambiguator to duplicate assoc items) - rust-lang#115948 (rustdoc: show crate name beside smaller logo) - rust-lang#116444 (add test for const-eval error in dead code during monomorphization) - rust-lang#116503 (Update docs for mips target tier demotion.) - rust-lang#116559 (Mark `new_in` as `const` for BTree collections) - rust-lang#116560 (In smir use `FxIndexMap` to store indexed ids) - rust-lang#116574 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#109422 (rustdoc-search: add impl disambiguator to duplicate assoc items) - rust-lang#116250 (On type error of closure call argument, point at earlier calls that affected inference) - rust-lang#116444 (add test for const-eval error in dead code during monomorphization) - rust-lang#116503 (Update docs for mips target tier demotion.) - rust-lang#116559 (Mark `new_in` as `const` for BTree collections) - rust-lang#116560 (In smir use `FxIndexMap` to store indexed ids) - rust-lang#116574 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116444 - RalfJung:broken-unused-const, r=oli-obk add test for const-eval error in dead code during monomorphization

rustbot assigned davidtwco Oct 5, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2023

RalfJung mentioned this pull request Oct 5, 2023

Are (non-free) generic constants guaranteed to be evaluated? #112090

Closed

RalfJung commented Oct 5, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

RalfJung force-pushed the broken-unused-const branch from d51b41c to db4a513 Compare October 5, 2023 08:09

RalfJung mentioned this pull request Oct 5, 2023

Monomorphization-time error handler does not point at constants #116456

Open

RalfJung force-pushed the broken-unused-const branch from db4a513 to 1805d2e Compare October 7, 2023 11:00

This comment has been minimized.

Sign in to view

RalfJung force-pushed the broken-unused-const branch from 1805d2e to 8dd1379 Compare October 7, 2023 23:56

This comment has been minimized.

Sign in to view

add test for const-eval error in dead code during monomorphization

5e1b0cb

RalfJung force-pushed the broken-unused-const branch from 8dd1379 to 5e1b0cb Compare October 8, 2023 15:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 10, 2023

Rollup merge of rust-lang#116444 - RalfJung:broken-unused-const, r=ol…

8296cf8

…i-obk add test for const-eval error in dead code during monomorphization

matthiaskrgr mentioned this pull request Oct 10, 2023

Rollup of 7 pull requests #116601

Closed

GuillaumeGomez mentioned this pull request Oct 10, 2023

Rollup of 7 pull requests #116605

Merged

bors merged commit bbaf6bd into rust-lang:master Oct 10, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 10, 2023

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2023

Unrolled build for rust-lang#116444

538c6b8

Rollup merge of rust-lang#116444 - RalfJung:broken-unused-const, r=oli-obk add test for const-eval error in dead code during monomorphization

RalfJung deleted the broken-unused-const branch October 11, 2023 17:09

Dajamante mentioned this pull request Oct 12, 2023

Pull upstream master 2023 10 12 ferrocene/ferrocene#48

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add test for const-eval error in dead code during monomorphization #116444

add test for const-eval error in dead code during monomorphization #116444

RalfJung commented Oct 5, 2023

rustbot commented Oct 5, 2023

RalfJung Oct 5, 2023

oli-obk Oct 5, 2023

This comment has been minimized.

This comment has been minimized.

RalfJung commented Oct 7, 2023

This comment has been minimized.

oli-obk commented Oct 10, 2023

bors commented Oct 10, 2023

add test for const-eval error in dead code during monomorphization #116444

add test for const-eval error in dead code during monomorphization #116444

Conversation

RalfJung commented Oct 5, 2023

rustbot commented Oct 5, 2023

RalfJung Oct 5, 2023

Choose a reason for hiding this comment

oli-obk Oct 5, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

RalfJung commented Oct 7, 2023

This comment has been minimized.

oli-obk commented Oct 10, 2023

bors commented Oct 10, 2023