Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_hir_pretty cleanups #116625

Merged
merged 4 commits into from
Oct 12, 2023
Merged

rustc_hir_pretty cleanups #116625

merged 4 commits into from
Oct 12, 2023

Conversation

nnethercote
Copy link
Contributor

Just some improvements I found while looking through this code.

r? @fee1-dead

There are several that are unused and can be removed.

And there are some calls to `to_string`, which can be expressed more
nicely as a `foo_to_string` call, and then `to_string` need not be
`pub`. (This requires adding `pat_to_string`).
- Remove an out-of-date comment. (There is no `PpAnn` implementation for `hir::Crate`.)
- Remove a low-value comment.
- And break a very long comment.
Remove and inline `new_from_input`, because it has a single call site.
And move `attrs` into the earlier `impl` block.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 12, 2023

📌 Commit 7d35902 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2023
…e1-dead

`rustc_hir_pretty` cleanups

Just some improvements I found while looking through this code.

r? `@fee1-dead`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#116593 (Add unstable book page for the no-jump-tables codegen option)
 - rust-lang#116625 (`rustc_hir_pretty` cleanups)
 - rust-lang#116642 (Handle several `#[diagnostic::on_unimplemented]` attributes correctly)
 - rust-lang#116654 (coverage: Clarify loop-edge detection and graph traversal)
 - rust-lang#116669 (Fix mips platform support entries.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b1867a into rust-lang:master Oct 12, 2023
11 checks passed
@rustbot rustbot added this to the 1.75.0 milestone Oct 12, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2023
Rollup merge of rust-lang#116625 - nnethercote:rustc_hir_pretty, r=fee1-dead

`rustc_hir_pretty` cleanups

Just some improvements I found while looking through this code.

r? ``@fee1-dead``
@nnethercote nnethercote deleted the rustc_hir_pretty branch October 12, 2023 19:04
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Oct 13, 2023
50: Automated pull from upstream `master` r=Dajamante a=github-actions[bot]


This PR pulls the following changes from the upstream repository:

* rust-lang/rust#116619
* rust-lang/rust#115964
* rust-lang/rust#116391
* rust-lang/rust#116510
* rust-lang/rust#116671
  * rust-lang/rust#116669
  * rust-lang/rust#116654
  * rust-lang/rust#116642
  * rust-lang/rust#116625
  * rust-lang/rust#116593
* rust-lang/rust#116649
* rust-lang/rust#116600
* rust-lang/rust#116628



Co-authored-by: Nadrieril <[email protected]>
Co-authored-by: Scott McMurray <[email protected]>
Co-authored-by: bjorn3 <[email protected]>
Co-authored-by: Nicholas Nethercote <[email protected]>
Co-authored-by: Trevor Gross <[email protected]>
Co-authored-by: Georg Semmler <[email protected]>
Co-authored-by: Guillaume Gomez <[email protected]>
Co-authored-by: Gurinder Singh <[email protected]>
Co-authored-by: bors <[email protected]>
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 21, 2023
…e1-dead

`rustc_hir_pretty` cleanups

Just some improvements I found while looking through this code.

r? ``@fee1-dead``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants