-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: correctly clean cross-crate opaque types #116735
rustdoc: correctly clean cross-crate opaque types #116735
Conversation
☔ The latest upstream changes (presumably #117405) made this pull request unmergeable. Please resolve the merge conflicts. |
6835191
to
a501bbe
Compare
@fmease any updates on it? r? rustdoc |
Ye, this PR could be merged as is (once I've removed some of the temporary FIXME comments). It's a draft since it's not super DRY and it should be generalized to fix more issues (some of which are mentioned in #113015). However, that'd require rewriting a lot of things which I didn't have the energy to do yet. Imma decide how to proceed today or in the coming days. |
☔ The latest upstream changes (presumably #121370) made this pull request unmergeable. Please resolve the merge conflicts. |
@fmease any updates on this? thanks |
Coincidentally I will send a new and more extensive PR in a few hours hopefully 🤞, one that should fix #113015 completely. Closing this PR. |
Opening a PR for a patch I had lying around for roughly 3 months to motivate myself to finish it.
Fixes bevyengine/bevy#8898 (#113015, subitem (1)).
Part of #113015.
Before/after (cross-crate re-export scenario):
Draft: See FIXMEs.
r? @ghost