Use elaboration to turn ~const bounds into non-const bounds #116872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
elaborate-host-effect
branch
from
d215b0b to
3dd95d2
Compare
fee1-dead
reviewed
Oct 18, 2023
Comment on lines
-224
to
+231
| // HACK(eddyb) should get the original `Span`. | ||
| let span = tcx.def_span(def_id); | ||
| ty::GenericPredicates { | ||
| parent: None, | ||
| predicates: tcx.arena.alloc_from_iter( | ||
| self.param_env.caller_bounds().iter().filter_map(|predicate| { | ||
| match predicate.kind().skip_binder() { | ||
| ty::ClauseKind::Trait(data) if data.self_ty().is_param(index) => { | ||
| // HACK(eddyb) should get the original `Span`. | ||
| let span = tcx.def_span(def_id); |
😅 this is the same thing I had in my own attempt at effect generics last year. I'll compare the impls to see if I found some other subtle issues due to the higher test coverage compared to the current effects impl |
|
☔ The latest upstream changes (presumably #116885) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
4 tasks
|
This is superseded (in the other direction) by #119721. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels slightly less ad-hoc, and is an attempt at this comment: #116756 (comment)
The only thing that I don't like is the filtering in
one_bound_for_assoc_type-- I wonder if I should filter somewhere else?r? @fee1-dead or @oli-obk