Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri subtree update #117579

Merged
merged 24 commits into from
Nov 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c2f232e
add aarch64-apple-darwin to list of supported targets
RalfJung Oct 27, 2023
5f3d81a
Auto merge of #3144 - RalfJung:supported, r=oli-obk
bors Oct 27, 2023
052539e
data-race: preserve structured access information longer, and don't u…
RalfJung Oct 27, 2023
278965a
give some more help for the unusual data races
RalfJung Oct 27, 2023
e298453
Preparing for merge from rustc
Oct 28, 2023
d7e49c0
Merge from rustc
Oct 28, 2023
293501b
fmt
Oct 28, 2023
6212cc6
Auto merge of #3147 - rust-lang:rustup-2023-10-28, r=saethlin
bors Oct 28, 2023
0b6c30a
atomic_op → atomic_rmw_op
RalfJung Oct 28, 2023
9b5b4dd
consolidate and extend testing for _ patterns discarding the place
RalfJung Oct 28, 2023
d176900
add some tests specifically for validity checks arising from match bi…
RalfJung Oct 28, 2023
fb028cb
Auto merge of #3148 - RalfJung:underscore-patterns, r=RalfJung
bors Oct 28, 2023
bd81a58
accept some atomic loads from read-only memory
RalfJung Oct 28, 2023
2c9baab
Auto merge of #3149 - RalfJung:atomic-readonly-loads, r=RalfJung
bors Oct 28, 2023
98eb384
make sure we catch UB with _ pattern in various syntactic positions
RalfJung Oct 30, 2023
de09bf5
Auto merge of #3150 - RalfJung:undercore-match, r=RalfJung
bors Oct 30, 2023
4c3eb37
Preparing for merge from rustc
Nov 2, 2023
869827f
Merge from rustc
Nov 2, 2023
1a08886
Auto merge of #3153 - rust-lang:rustup-2023-11-02, r=RalfJung
bors Nov 2, 2023
99417f2
Preparing for merge from rustc
Nov 4, 2023
fad8536
Merge from rustc
Nov 4, 2023
5b18703
fmt
Nov 4, 2023
1b2e4a9
Auto merge of #3154 - rust-lang:rustup-2023-11-04, r=RalfJung
bors Nov 4, 2023
2ef639d
Auto merge of #3145 - RalfJung:data-race-error, r=RalfJung
bors Nov 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/tools/miri/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,10 @@ degree documented below):
- All Rust [Tier 1 targets](https://doc.rust-lang.org/rustc/platform-support.html) are supported by
Miri. They are all checked on Miri's CI, and some (at least one per OS) are even checked on every
Rust PR, so the shipped Miri should always work on these targets.
- We also support `s390x-unknown-linux-gnu` as our "big-endian target of choice".
- `aarch64-apple-darwin` is supported.
- `s390x-unknown-linux-gnu` is supported as our "big-endian target of choice".
- For every other target with OS `linux`, `macos`, or `windows`, Miri should generally work, but we
make no promises.
make no promises and we don't run tests for such targets.
- For targets on other operating systems, even basic operations such as printing to the standard
output might not work, and Miri might fail before even reaching the `main` function.

Expand Down
2 changes: 1 addition & 1 deletion src/tools/miri/rust-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2e4e2a8f288f642cafcc41fff211955ceddc453d
3aaa0f57b7b877ef58532a8de075d1e5a79142bf
18 changes: 13 additions & 5 deletions src/tools/miri/src/bin/miri.rs
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ fn run_compiler(
mut args: Vec<String>,
target_crate: bool,
callbacks: &mut (dyn rustc_driver::Callbacks + Send),
using_internal_features: std::sync::Arc<std::sync::atomic::AtomicBool>
using_internal_features: std::sync::Arc<std::sync::atomic::AtomicBool>,
) -> ! {
if target_crate {
// Miri needs a custom sysroot for target crates.
Expand Down Expand Up @@ -275,7 +275,8 @@ fn run_compiler(
// Invoke compiler, and handle return code.
let exit_code = rustc_driver::catch_with_exit_code(move || {
rustc_driver::RunCompiler::new(&args, callbacks)
.set_using_internal_features(using_internal_features).run()
.set_using_internal_features(using_internal_features)
.run()
});
std::process::exit(exit_code)
}
Expand All @@ -297,7 +298,8 @@ fn main() {
// If the environment asks us to actually be rustc, then do that.
if let Some(crate_kind) = env::var_os("MIRI_BE_RUSTC") {
// Earliest rustc setup.
let using_internal_features = rustc_driver::install_ice_hook(rustc_driver::DEFAULT_BUG_REPORT_URL, |_| ());
let using_internal_features =
rustc_driver::install_ice_hook(rustc_driver::DEFAULT_BUG_REPORT_URL, |_| ());
rustc_driver::init_rustc_env_logger(&handler);

let target_crate = if crate_kind == "target" {
Expand All @@ -318,7 +320,8 @@ fn main() {
}

// Add an ICE bug report hook.
let using_internal_features = rustc_driver::install_ice_hook("https://github.com/rust-lang/miri/issues/new", |_| ());
let using_internal_features =
rustc_driver::install_ice_hook("https://github.com/rust-lang/miri/issues/new", |_| ());

// Init loggers the Miri way.
init_early_loggers(&handler);
Expand Down Expand Up @@ -581,5 +584,10 @@ fn main() {

debug!("rustc arguments: {:?}", rustc_args);
debug!("crate arguments: {:?}", miri_config.args);
run_compiler(rustc_args, /* target_crate: */ true, &mut MiriCompilerCalls { miri_config }, using_internal_features)
run_compiler(
rustc_args,
/* target_crate: */ true,
&mut MiriCompilerCalls { miri_config },
using_internal_features,
)
}
Loading
Loading