-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap bump #117875
Bootstrap bump #117875
Conversation
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
rustfmt changes seem potentially more widespread than I'd expect, so asked on Zulip about them - https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/expected.20changes.20in.20bootstrap.20bump.3F cc @rust-lang/rustdoc as well |
er, @rust-lang/rustfmt, sorry |
This comment has been minimized.
This comment has been minimized.
97c4b78
to
a324415
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
Acknowledge seeing this, from a quick glance many of the changes look related to things like the newly added support for formatting let chains (some of the diffs are to lines contained within the body of a let chain). Can take a deeper look later though |
Please don't add the link to the rustdoc team in your replies. We get re-subscribed every time. 😅 |
I've investigated the failure. This due to the way the cranelift build system and bootstrap interacts. The short term solution would be to add it the our list of |
cg_clif's build system has to respect |
Adding |
Adding that here should work:
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
This comment has been minimized.
This comment has been minimized.
@bors r- |
d7a62e4
to
9e8edb6
Compare
@bors r=clubby789 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1be1e84): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.207s -> 676.569s (0.20%) |
|
Bumps bootstrap compiler to just-released beta.
https://forge.rust-lang.org/release/process.html#master-bootstrap-update-t-2-day-tuesday