doc: add release notes to standalone doc bundle #117888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @onur-ozkan (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/releases
branch
from
7df8467 to
70ba2a2
Compare
This comment has been minimized.
This comment has been minimized.
This is a workaround for rust-lang#101714 on top of being a useful addition in its own right. It is intended to change the "canonical URL" for viewing the release notes from GitHub, which is relatively slow, to a pre-rendered HTML file that loads from the same CDN as the standard library docs. It also means you get a copy of the release notes when installing the rust-docs with rustup.
notriddle
force-pushed
the
notriddle/releases
branch
from
70ba2a2 to
29f5d2c
Compare
onur-ozkan
reviewed
Nov 18, 2023
onur-ozkan
approved these changes
Nov 18, 2023
onur-ozkan
added
S-waiting-on-author
|
@bors rollup=iffy |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Onur Özkan <[email protected]>
notriddle
force-pushed
the
notriddle/releases
branch
from
c59660c to
a3d9003
Compare
|
While I like it very much, I don't want to make the decision alone, so I would like one more person to review it. r? Mark-Simulacrum |
|
r=me beyond the small comment |
|
@bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (290fc68): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 676.664s -> 677.922s (0.19%) |
notriddle
added a commit
to notriddle/promote-release
that referenced
this pull request
Feb 4, 2024
Now that https://dev-doc.rust-lang.org/1.76.0/releases.html exists, we can use it and not have to worry about rust-lang/rust#101714 any more. This is a follow-up for rust-lang/rust#117888
Mark-Simulacrum
pushed a commit
to rust-lang/promote-release
that referenced
this pull request
Feb 4, 2024
Now that https://dev-doc.rust-lang.org/1.76.0/releases.html exists, we can use it and not have to worry about rust-lang/rust#101714 any more. This is a follow-up for rust-lang/rust#117888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: http://notriddle.com/rustdoc-html-demo-5/release-notes/releases.html
This is a workaround for #101714 on top of being a useful addition in its own right. It is intended to change the "canonical URL" for viewing the release notes from GitHub, which is relatively slow, to a pre-rendered HTML file that loads from the same CDN as the standard library docs. It also means you get a copy of the release notes when installing the rust-docs with rustup.