effects: Run enforce_context_effects for all method calls
#118282
Conversation
rustbot
added
S-waiting-on-review
|
Some changes might have occurred in exhaustiveness checking cc @Nadrieril |
| @@ -336,7 +336,7 @@ fn from_str(s: &str) -> Result<bool, ()> { | |||
| } | |||
|
|
|||
| #[lang = "eq"] | |||
| #[const_trait] | |||
| // FIXME #[const_trait] | |||
There was a problem hiding this comment.
What breaks here, out of curiosity? from_str should be host = true, so why can't we evaluate the PartialEq obligation in the match above?
There was a problem hiding this comment.
I think the only explanation here for this breaking is that we begun checking == method calls. Having this led to ICEs about mismatched number of generic arguments for PartialEq.
|
@bors r+ |
bors
added
S-waiting-on-bors
…compiler-errors effects: Run `enforce_context_effects` for all method calls So that we also perform checks when overloaded `PartialEq`s are called. r? `@compiler-errors`
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111133 (Detect Python-like slicing and suggest how to fix) - rust-lang#114708 (Allow setting `rla` labels via `rustbot`) - rust-lang#117526 (Account for `!` arm in tail `match` expr) - rust-lang#118282 (effects: Run `enforce_context_effects` for all method calls) - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints) - rust-lang#118375 (Add -Zunpretty=stable-mir output test) r? `@ghost` `@rustbot` modify labels: rollup
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (e06c94d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.319s -> 673.509s (-0.12%) |
So that we also perform checks when overloaded
PartialEqs are called.r? @compiler-errors