Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miri subtree update #118284

Merged
merged 39 commits into from
Nov 25, 2023
Merged

Miri subtree update #118284

merged 39 commits into from
Nov 25, 2023

Conversation

RalfJung
Copy link
Member

No description provided.

RalfJung and others added 30 commits November 18, 2023 08:02
@RalfJung
miri script: fix RUSTC_GIT error message
abdfe4a
@bors
Auto merge of rust-lang#3174 - RalfJung:rustc-git, r=RalfJung
b7b919c 
miri script: fix RUSTC_GIT error message

Making this a flag is tricky since our command-line parsing is pretty crude.

Fixes rust-lang/miri#3173
@RalfJung
cargo-miri: when verbose, print where the sysroot is being built
eba8d29
@bors
Auto merge of rust-lang#3175 - RalfJung:sysroot-verbose, r=RalfJung
9ad93b3 
cargo-miri: when verbose, print where the sysroot is being built

Fixes rust-lang/miri#3169
@eduardosm
Improve wording of intrinsics-x86-*.rs header
cee4c57
@devnexen
libc-misc test freebsd fixes attempt
991e53a
@bors
Auto merge of rust-lang#3177 - devnexen:fix_pthread_misc_fbsd, r=Ralf…
6730f22 
…Jung

libc-misc test freebsd fixes attempt
@eduardosm
Implement all 16 AVX compare operators
81303e7 
`_mm_cmp_{ss,ps,sd,pd}` functions are AVX functions that use `llvm.x86.sse{,2}` prefixed intrinsics, so they were "accidentally" partially implemented when SSE and SSE2 intrinsics were implemented.

The 16 AVX compare operators are now implemented and tested.
@bors
Auto merge of rust-lang#3176 - eduardosm:cmp, r=RalfJung
607208c 
Implement all 16 AVX compare operators for 128-bit SIMD vectors

`_mm_cmp_{ss,ps,sd,pd}` functions are AVX functions that use `llvm.x86.sse{,2}.` prefixed intrinsics, so they were "accidentally" partially implemented when SSE and SSE2 intrinsics were implemented.

The 16 AVX compare operators are now implemented and tested.
@RalfJung
Preparing for merge from rustc
9007cc4
@RalfJung
Merge from rustc
eed24ac
@RalfJung
fmt
f1b944d
@bors
Auto merge of rust-lang#3182 - RalfJung:rustup, r=RalfJung
4926115 
Rustup
@eduardosm
Check that target features required by LLVM intrinsics are enabled
09358a0
@bors
Auto merge of rust-lang#3180 - eduardosm:check-intrinsics-target-feat…
41d7012 
…ure, r=RalfJung

Check that target features required by LLVM intrinsics are enabled

Fixes rust-lang/miri#3178
Preparing for merge from rustc
804afa4
Merge from rustc
03f19ab
@bors
Auto merge of rust-lang#3183 - rust-lang:rustup-2023-11-23, r=RalfJung
933bdbc 
Automatic Rustup
@RalfJung
detect and test for data races between setenv and getenv
4896c95
@RalfJung
remove stub android files that don't do anything
4b69e52
@bors
Auto merge of rust-lang#3184 - RalfJung:getenv, r=RalfJung
2a1e0ce 
detect and test for data races between setenv and getenv

But only on Unix; Windows doesn't have such a data race. Also make target_os_is_unix properly check for unix, which then makes our completely empty android files useless.
@eduardosm
Refactor float_to_int_checked to remove its generic parameter and r…
2855024 
…educe code duplication a bit
@bors
Auto merge of rust-lang#3185 - eduardosm:float_to_int_checked-generic…
44aceb5 
…, r=RalfJung

Refactor `float_to_int_checked` to remove its generic parameter and reduce code duplication a bit
@RalfJung
Preparing for merge from rustc
c174448
@RalfJung
Merge from rustc
a4a294a
@RalfJung
fmt
2df4fc0
@RalfJung
bless
34a8680
@bors
Auto merge of rust-lang#3187 - RalfJung:rustup, r=RalfJung
b7912d3 
Rustup
@RalfJung
make tests/utils work with edition 2015
69ea952
@RalfJung
read off_t at the right size for the current target
ce94b22
RalfJung and others added 9 commits November 25, 2023 10:33
@RalfJung
run tests on 32bit freebsd
b750b54
@bors
Auto merge of rust-lang#3190 - RalfJung:freebsd32, r=RalfJung
2132d78 
test Miri on 32bit FreeBSD
@RalfJung
run the provenance-gc=1 test on all targets, but only for some of the…
2a89b74 
… tests

before: only on Linux host, all tests
after: only the test suite itself (not cargo-miri or the mir-opt-level=4 run),
on all hosts for the host target and on Linux for all "full" targets.
@RalfJung
tweak ci.sh
695f1a5
@bors
Auto merge of rust-lang#3189 - RalfJung:ci, r=RalfJung
535db18 
run the provenance-gc=1 test on all targets, but only for the host tests

No need to slow down *all those tests* running on the Linux host... but lets cover each major OS at least once. We've had bugs that only some macOS-specific code in `getrandom` found, after all.

Let's see how much this affects timing on the macOS / Windows runners.
@RalfJung
Preparing for merge from rustc
2f825fb
@RalfJung
Merge from rustc
a0cf02a
@RalfJung
bless
feb3782
@bors
Auto merge of rust-lang#3191 - RalfJung:rustup, r=RalfJung
547598b 
Rustup
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Nov 25, 2023

📌 Commit 547598b has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
@bors
Copy link
Contributor

bors commented Nov 25, 2023

⌛ Testing commit 547598b with merge fe3038f...

@bors
Copy link
Contributor

bors commented Nov 25, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing fe3038f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2023
@bors bors merged commit fe3038f into rust-lang:master Nov 25, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 25, 2023
@bors bors mentioned this pull request Nov 25, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fe3038f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.1% [0.5%, 2.1%] 3
Improvements ✅
(primary)		 -3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.5% [-3.5%, -3.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.5% [-1.5%, -1.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.339s -> 675.133s (0.12%)
Artifact size: 313.28 MiB -> 313.36 MiB (0.02%)

@RalfJung RalfJung deleted the miri branch November 27, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @bors @rust-timer @Mark-Simulacrum @eduardosm @devnexen