Clean dead codes in miri #118399
Merged
Clean dead codes in miri #118399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
|
I think we used to need this for is_tty, and I figured I'd leave it around in case we need it again in the future. But I'd also be fine with removing this. @saethlin what do you think? @mu001999 for the future, please submit such Miri-only PRs at https://github.com/rust-lang/miri/ . But it's okay for now, we can land this one in rustc directly and sync it to Miri. |
|
I'm always in favor of deleting dead code. If we need it back, we have our commit history. |
|
Works for me. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#118193 (Add missing period in `std::process::Command` docs) - rust-lang#118222 (unify read_to_end and io::copy impls for reading into a Vec) - rust-lang#118323 (give dev-friendly error message for incorrect config profiles) - rust-lang#118378 (Perform LTO optimisations with wasm-ld + -Clinker-plugin-lto) - rust-lang#118399 (Clean dead codes in miri) - rust-lang#118410 (update test for new LLVM 18 codegen) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#118193 (Add missing period in `std::process::Command` docs) - rust-lang#118222 (unify read_to_end and io::copy impls for reading into a Vec) - rust-lang#118323 (give dev-friendly error message for incorrect config profiles) - rust-lang#118378 (Perform LTO optimisations with wasm-ld + -Clinker-plugin-lto) - rust-lang#118399 (Clean dead codes in miri) - rust-lang#118410 (update test for new LLVM 18 codegen) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2023
Rollup merge of rust-lang#118399 - mu001999:miri/cleanup, r=RalfJung Clean dead codes in miri Detected by rust-lang#118257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by #118257