-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix const drop checking #118689
Fix const drop checking #118689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! r=me after the comment nit
5b8b612
to
efe8ae7
Compare
@bors r=fee1-dead |
The job Click to see the possible cause of the failure (guessed by this bot)
|
…-dead Fix const drop checking Fixes confirmation of `~const Destruct` and const drops. r? fee1-dead
…-dead Fix const drop checking Fixes confirmation of `~const Destruct` and const drops. r? fee1-dead
☀️ Test successful - checks-actions |
Finished benchmarking commit (ae612be): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.729s -> 675.635s (0.13%) |
Fixes confirmation of
~const Destruct
and const drops.r? fee1-dead