Update measureme crate to version 11 #119111

michaelwoerister · 2023-12-19T10:15:59Z

perf.rlo has been updated to use 11.0.0 already, so it should be able to handle the new file format.

Fixes #99282
Fixes #119103

rustbot · 2023-12-19T10:16:10Z

The Miri subtree was changed

cc @rust-lang/miri

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

klensy · 2023-12-19T10:38:40Z

perf.rlo has been updated to use 11.0.0 already

Where?
https://github.com/rust-lang/rustc-perf/blob/dc2ac6a2d637a567332c5e41d825a365b5ed7561/Cargo.lock#L1466-L1490

michaelwoerister · 2023-12-19T10:41:43Z

See https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/measureme.20update/near/408722154

That Cargo.lock is curious though.

michaelwoerister · 2023-12-19T10:46:19Z

rustc-perf mostly relies on the commandline tools, IIUC. The only place a measureme crate is pulled in as dependency is here: https://github.com/rust-lang/rustc-perf/blob/dc2ac6a2d637a567332c5e41d825a365b5ed7561/site/Cargo.toml#L42

It takes the version from the master branch. I don't recommend that but at least it should stay up-to-date.

klensy · 2023-12-19T10:51:51Z

So in linked script https://github.com/rust-lang/rustc-perf/blob/cbdf7fbe93760db6be2ce9b4c27ba4bdea332971/collector/collect.sh#L23 commit not pinned too.

lqd · 2023-12-19T11:42:11Z

This should also fix #119103

Kobzol · 2023-12-19T14:26:56Z

@bors try @rust-timer queue

Let's see if perf.RLO handles it.

bors · 2023-12-19T14:28:06Z

⌛ Trying commit 3ac7d64 with merge a19277d...

Update measureme crate to version 11.0.0 perf.rlo has been updated to use 11.0.0 already, so it should be able to handle the new file format. r? `@Mark-Simulacrum` Fixes rust-lang#99282 Fixes rust-lang#119103

bors · 2023-12-19T15:54:27Z

☀️ Try build successful - checks-actions
Build commit: a19277d (a19277d089610031f64bfb2471fd39f64a18f594)

rust-timer · 2023-12-19T17:24:29Z

Finished benchmarking commit (a19277d): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.6%, 2.6%]	4
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[0.6%, 2.6%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.757s -> 671.691s (-0.16%)
Artifact size: 312.46 MiB -> 312.47 MiB (0.00%)

lqd · 2023-12-19T17:31:11Z

It doesn't work, so I'll update rustc-perf to the new measureme. (edit: rust-lang/rustc-perf#1779)

wesleywiser

r=me when ready 👍

lqd · 2023-12-20T09:43:52Z

@bors try

bors · 2023-12-20T09:45:01Z

⌛ Trying commit 3ac7d64 with merge adf2bdb...

Update measureme crate to version 11.0.0 perf.rlo has been updated to use 11.0.0 already, so it should be able to handle the new file format. r? `@Mark-Simulacrum` Fixes rust-lang#99282 Fixes rust-lang#119103

bors · 2023-12-20T11:11:04Z

☀️ Try build successful - checks-actions
Build commit: adf2bdb (adf2bdbed168bec31748d732d893bfd4b2203959)

lqd · 2023-12-23T13:57:13Z

The update is merged on rustc-perf and deployed, and everything seems to work fine: the after or diff self-profile page for example, or other processed links like flamegraph, codegen-schedule or Perfetto/crox (I'm not sure if FF's profiler currently works).

@bors r=wesleywiser,lqd

bors · 2023-12-23T13:57:15Z

📌 Commit 3ac7d64 has been approved by wesleywiser,lqd

It is now in the queue for this repository.

bors · 2023-12-23T18:21:25Z

⌛ Testing commit 3ac7d64 with merge d275e55...

rustbot · 2024-01-13T15:32:45Z

Could not assign reviewer from: Mark-Simulacrum.
User(s) Mark-Simulacrum are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

michaelwoerister · 2024-01-15T08:46:23Z

The 11.0.1 release which fixes the big-endian compilation error is out.

@rustbot ready

klensy · 2024-01-15T08:59:02Z

The 11.0.1 release which fixes the big-endian compilation error is out.

rustc-perf needs this bump too?

Mark-Simulacrum · 2024-01-16T19:55:59Z

@bors try @rust-timer queue

bors · 2024-01-16T19:57:10Z

⌛ Trying commit ac58f9a with merge 98c5468...

Update measureme crate to version 11 perf.rlo has been updated to use 11.0.0 already, so it should be able to handle the new file format. r? `@Mark-Simulacrum` Fixes rust-lang#99282 Fixes rust-lang#119103

bors · 2024-01-16T21:23:34Z

☀️ Try build successful - checks-actions
Build commit: 98c5468 (98c54681e2177b6ef13d487fbfa699b6ba15833d)

lqd · 2024-01-16T21:27:33Z

The 11.0.1 release which fixes the big-endian compilation error is out.

rustc-perf needs this bump too?

It shouldn't for our perf.rlo uses, as the previous successful runs with v11 showed. For people running rustc-perf on big-endian targets it probably would, but can be done in parallel and wouldn't need to block this PR per se?

Mark-Simulacrum · 2024-01-16T21:29:09Z

(happy to r=me if we don't want to wait for confirmation, but I figured it's cheap to check)

klensy · 2024-01-16T21:34:50Z

wouldn't need to block this PR per se?

No block ofc, just possible todo.

lqd · 2024-01-16T21:51:10Z

We can wait for results for sure. However, I wanted to do the bump to ease @klensy's mind but couldn't: 11.0.1 wasn't pushed to the stable branch, and rustc-perf's site and collector will be on 11.0.0 for the results.

rust-timer · 2024-01-17T01:01:19Z

Finished benchmarking commit (98c5468): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 663.55s -> 662.594s (-0.14%)
Artifact size: 308.22 MiB -> 308.27 MiB (0.02%)

michaelwoerister · 2024-01-17T08:02:13Z

@lqd, there's a PR open to update the stable branch: rust-lang/measureme#224

You could try to r+ it via bors. I'm not sure about the exact permissions at the moment (but I think we should give r+ to wg-performance).

michaelwoerister · 2024-01-17T08:06:08Z

The perf run results seem to be displayed normally.

@bors r=Mark-Simulacrum

bors · 2024-01-17T08:06:11Z

📌 Commit ac58f9a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

lqd · 2024-01-17T08:33:31Z

I'm not sure about the exact permissions at the moment

(According to the team config, only t-compiler not contributors.)

bors · 2024-01-17T09:32:07Z

⌛ Testing commit ac58f9a with merge 25b706c...

bors · 2024-01-17T11:45:43Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 25b706c to master...

rust-timer · 2024-01-17T13:03:03Z

Finished benchmarking commit (25b706c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.76s -> 664.038s (-0.41%)
Artifact size: 308.34 MiB -> 308.36 MiB (0.01%)

rustbot assigned Mark-Simulacrum Dec 19, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2023

wesleywiser approved these changes Dec 19, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2024

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 16, 2024

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 17, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 17, 2024

bors merged commit 25b706c into rust-lang:master Jan 17, 2024
12 checks passed

rustbot added this to the 1.77.0 milestone Jan 17, 2024

Update measureme crate to version 11 #119111

Update measureme crate to version 11 #119111

Conversation

michaelwoerister commented Dec 19, 2023 • edited Loading

rustbot commented Dec 19, 2023

klensy commented Dec 19, 2023

michaelwoerister commented Dec 19, 2023

michaelwoerister commented Dec 19, 2023

klensy commented Dec 19, 2023

lqd commented Dec 19, 2023

Kobzol commented Dec 19, 2023

This comment has been minimized.

bors commented Dec 19, 2023

bors commented Dec 19, 2023

This comment has been minimized.

rust-timer commented Dec 19, 2023

Overall result: ❌ regressions - no action needed

lqd commented Dec 19, 2023 • edited Loading

wesleywiser left a comment

Choose a reason for hiding this comment

lqd commented Dec 20, 2023

bors commented Dec 20, 2023

bors commented Dec 20, 2023

lqd commented Dec 23, 2023

bors commented Dec 23, 2023

bors commented Dec 23, 2023

rustbot commented Jan 13, 2024

michaelwoerister commented Jan 15, 2024

klensy commented Jan 15, 2024

Mark-Simulacrum commented Jan 16, 2024

This comment has been minimized.

bors commented Jan 16, 2024

bors commented Jan 16, 2024

This comment has been minimized.

lqd commented Jan 16, 2024 • edited Loading

Mark-Simulacrum commented Jan 16, 2024

klensy commented Jan 16, 2024

lqd commented Jan 16, 2024 • edited Loading

rust-timer commented Jan 17, 2024

Overall result: no relevant changes - no action needed

michaelwoerister commented Jan 17, 2024

michaelwoerister commented Jan 17, 2024

bors commented Jan 17, 2024

lqd commented Jan 17, 2024

bors commented Jan 17, 2024

bors commented Jan 17, 2024

rust-timer commented Jan 17, 2024

Overall result: no relevant changes - no action needed

michaelwoerister commented Dec 19, 2023 •

edited

Loading

lqd commented Dec 19, 2023 •

edited

Loading

lqd commented Jan 16, 2024 •

edited

Loading

lqd commented Jan 16, 2024 •

edited

Loading