Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated missing-tools bootstrap flag #119373

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 28, 2023

This PR removes the usage of --enable-missing-tools in CI, as this config option is no longer used. It also removes dist.missing-tools config completely.

Let me know which commits should I remove (if any).

Fixes: #79249

r? @onur-ozkan

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 28, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan
Copy link
Member

We have #107830 PR which aims to close #79249 completely. Since author is inactive, I think we can cherry-pick the commit from that PR and fix the conflicts and review notes.

@Kobzol Kobzol force-pushed the missing-tools-bootstrap branch from 144af15 to da29854 Compare December 28, 2023 15:41
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Kobzol Kobzol changed the title Remove usage of deprecated --enable-missing-tools flag in CI Remove usage of deprecated missing-tools bootstrap flag Dec 28, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2023

Could not assign reviewer from: onur-ozkan.
User(s) onur-ozkan are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor notes, other than that LGTM

src/bootstrap/src/utils/change_tracker.rs Outdated Show resolved Hide resolved
src/bootstrap/src/core/config/config.rs Outdated Show resolved Hide resolved
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2023
@Kobzol Kobzol force-pushed the missing-tools-bootstrap branch from da29854 to fdeb8c5 Compare December 28, 2023 19:23
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 28, 2023

📌 Commit fdeb8c5 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 28, 2023
@bors
Copy link
Contributor

bors commented Dec 28, 2023

⌛ Testing commit fdeb8c5 with merge 03c2a10...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2023
…ur-ozkan

Remove usage of deprecated `missing-tools` bootstrap flag

This PR removes the usage of `--enable-missing-tools` in CI, as this config option is no longer used. It also removes `dist.missing-tools` config completely.

Let me know which commits should I remove (if any).

Fixes: rust-lang#79249

r? `@onur-ozkan`
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling cranelift-codegen v0.103.0
[RUSTC-TIMING] build_script_build test:false 0.878
[RUSTC-TIMING] regalloc2 test:false 5.029
[RUSTC-TIMING] gimli test:false 9.272
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Fri Dec 29 00:02:07 UTC 2023
  local time: Fri Dec 29 00:02:07 UTC 2023
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

@bors
Copy link
Contributor

bors commented Dec 29, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 29, 2023
@onur-ozkan
Copy link
Member

Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
@bors
Copy link
Contributor

bors commented Dec 29, 2023

⌛ Testing commit fdeb8c5 with merge 29abb90...

@bors
Copy link
Contributor

bors commented Dec 29, 2023

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 29abb90 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2023
@bors bors merged commit 29abb90 into rust-lang:master Dec 29, 2023
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 29, 2023
@Kobzol Kobzol deleted the missing-tools-bootstrap branch December 29, 2023 18:38
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (29abb90): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)
3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)
-3.4% [-3.6%, -3.1%] 2
Improvements ✅
(secondary)
-2.2% [-2.3%, -2.2%] 2
All ❌✅ (primary) -1.2% [-3.6%, 3.3%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.694s -> 669.249s (-0.36%)
Artifact size: 312.04 MiB -> 312.02 MiB (-0.01%)

tshepang added a commit to ferrocene/ferrocene that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove missing_tools config
6 participants