-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of deprecated missing-tools
bootstrap flag
#119373
Conversation
This PR modifies If appropriate, please update |
144af15
to
da29854
Compare
This PR modifies If appropriate, please update |
--enable-missing-tools
flag in CImissing-tools
bootstrap flag
Could not assign reviewer from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 minor notes, other than that LGTM
da29854
to
fdeb8c5
Compare
@bors r+ |
…ur-ozkan Remove usage of deprecated `missing-tools` bootstrap flag This PR removes the usage of `--enable-missing-tools` in CI, as this config option is no longer used. It also removes `dist.missing-tools` config completely. Let me know which commits should I remove (if any). Fixes: rust-lang#79249 r? `@onur-ozkan`
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (29abb90): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.694s -> 669.249s (-0.36%) |
Removed at rust-lang/rust#119373
This PR removes the usage of
--enable-missing-tools
in CI, as this config option is no longer used. It also removesdist.missing-tools
config completely.Let me know which commits should I remove (if any).
Fixes: #79249
r? @onur-ozkan