Rollup of 5 pull requests #119722
Rollup of 5 pull requests #119722
Conversation
The documentation today does not give a complete treatment of pinning from first principles, which appropriately describes how to design types that use it, nor does it provide formal statements of the guarantees users need to be aware of. This rewrite attempts to address these in a way that makes the concept more approachable while also making the documentation more normative.
We don't need to go into that much depth at this stage
Co-authored-by: Ralf Jung <[email protected]> Co-authored-by: Daniel Henry-Mantilla <[email protected]>
Rewrite `pin` module documentation to clarify usage and invariants The documentation of `pin` today does not give a complete treatment of pinning from first principles, nor does it adequately help build intuition and understanding for how the different elements of the pinning story fit together. This rewrite attempts to address these in a way that makes the concept more approachable while also making the documentation more normative. This PR picks up where `@mcy` left off in rust-lang#88500 (thanks to him for the original work and `@Manishearth` for mentioning it such that I originally found it). I've directly incorporated much of the feedback left on the original PR and have rewritten and changed some of the main conceits of the prose to better adhere to the feedback from the reviewers on that PR or just explain something in (hopefully) a better way.
… r=fmease Impl trait diagnostic tweaks 1. Tweak some names for `impl Trait` being used in the wrong position 2. Remove two helper functions that are no longer needed since RPITIT is stable, and which causes matches to be a bit obtuse. 3. Split and fix the part where the error notes that it's "only allowed in XX" Fixes rust-lang#119629
…-impls, r=compiler-errors Support `~const` in associated functions in trait impls Fixes rust-lang#119700.
…lstrieb Unions are not `PointerLike` I introduced the `PointerLike` trait to enforce `dyn*` coercions only from types that share the same ABI as a pointer. On top of needing to be scalar, they also should not be unions, since CTFE chokes on scalar reads for union types. Fixes rust-lang#119695
Delete unused makefile in tests/ui ??????????
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 75c68cfd2b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (76101ee): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Warning ⚠: The following benchmark(s) failed to build:
cc @rust-lang/wg-compiler-performance Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 665.982s -> 666.019s (0.01%) |
|
This was most probably the slow S3 self-profile issue again. The following PR (#119693 (comment)) was fine. |
|
@rustbot label: +perf-regression-triaged |
rustbot
added
the
perf-regression-triaged
Successful merges:
pinmodule documentation to clarify usage and invariants #116129 (Rewritepinmodule documentation to clarify usage and invariants)~constin associated functions in trait impls #119705 (Support~constin associated functions in trait impls)PointerLike#119708 (Unions are notPointerLike)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup