Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch NonZero alias direction. #120165

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Switch NonZero alias direction. #120165

merged 5 commits into from
Jan 29, 2024

Conversation

reitermarkus
Copy link
Contributor

Step 4 mentioned in #100428 (review).

Depends on #120160.

r? @dtolnay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 20, 2024
@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch from 4d13c28 to 96547fa Compare January 20, 2024 17:11
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch 2 times, most recently from e050499 to 2af5eef Compare January 20, 2024 18:19
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch 2 times, most recently from 602c53e to 88b1f00 Compare January 20, 2024 18:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch 2 times, most recently from 69191b6 to fcebdff Compare January 20, 2024 20:29
@reitermarkus reitermarkus marked this pull request as ready for review January 20, 2024 20:41
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch from fcebdff to 502f995 Compare January 21, 2024 17:07
@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch from 502f995 to 67f8368 Compare January 21, 2024 18:15
@reitermarkus reitermarkus requested a review from kadiwa4 January 21, 2024 18:16
@reitermarkus reitermarkus force-pushed the nonzero-switch-alias-direction branch from 67f8368 to 71044e6 Compare January 21, 2024 18:57
@reitermarkus reitermarkus mentioned this pull request Jan 23, 2024
Closed
21 tasks
@dtolnay dtolnay force-pushed the nonzero-switch-alias-direction branch from 71044e6 to bd1b265 Compare January 24, 2024 00:52
@dtolnay dtolnay added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2024
dtolnay
dtolnay approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Jan 24, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 24, 2024

📌 Commit bd1b265 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2024
@reitermarkus
Copy link
Contributor Author

@bors r=dtolnay

@bors
Copy link
Contributor

bors commented Jan 27, 2024

📌 Commit 021739c has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2024
@bors
Auto merge of rust-lang#120165 - reitermarkus:nonzero-switch-alias-di…
9582040 
…rection, r=dtolnay

Switch `NonZero` alias direction.

Step 4 mentioned in rust-lang#100428 (review).

Depends on rust-lang#120160.

r? `@dtolnay`
@bors
Copy link
Contributor

bors commented Jan 27, 2024

⌛ Testing commit 021739c with merge 9582040...

@bors
Copy link
Contributor

bors commented Jan 27, 2024

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2024
@fmease
Copy link
Member

fmease commented Jan 27, 2024

@bors retry reoccurring timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 28, 2024

⌛ Testing commit 021739c with merge bf19196...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120165 - reitermarkus:nonzero-switch-alias-di…
bf19196 
…rection, r=dtolnay

Switch `NonZero` alias direction.

Step 4 mentioned in rust-lang#100428 (review).

Depends on rust-lang#120160.

r? `@dtolnay`
@bors
Copy link
Contributor

bors commented Jan 28, 2024

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2024
@rust-log-analyzer
Copy link
Collaborator

The job dist-aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@dtolnay
Copy link
Member

dtolnay commented Jan 28, 2024

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2024
@bors
Copy link
Contributor

bors commented Jan 29, 2024

⌛ Testing commit 021739c with merge fb4bca0...

@bors
Copy link
Contributor

bors commented Jan 29, 2024

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing fb4bca0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2024
@bors bors merged commit fb4bca0 into rust-lang:master Jan 29, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 29, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fb4bca0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.7% [0.9%, 4.7%] 15
Regressions ❌
(secondary)		 2.6% [0.8%, 4.8%] 52
Improvements ✅
(primary)		 -2.0% [-2.2%, -1.7%] 2
Improvements ✅
(secondary)		 -4.2% [-9.6%, -1.5%] 4
All ❌✅ (primary) 2.2% [-2.2%, 4.7%] 17

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.1%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [0.0%, 0.1%] 6

Bootstrap: 661.733s -> 660.078s (-0.25%)
Artifact size: 308.02 MiB -> 308.02 MiB (0.00%)

@reitermarkus reitermarkus deleted the nonzero-switch-alias-direction branch January 29, 2024 20:52
@dtolnay dtolnay mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay requested changes

@kadiwa4 kadiwa4 Awaiting requested review from kadiwa4

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
9 participants
@reitermarkus @rust-log-analyzer @rustbot @dtolnay @bors @fmease @matthiaskrgr @rust-timer @kadiwa4