Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: update freebsd and netbsd base specs. #120188

Merged
merged 2 commits into from
Jan 23, 2024
Merged

compiler: update freebsd and netbsd base specs. #120188

merged 2 commits into from
Jan 23, 2024

Conversation

devnexen
Copy link
Contributor

both support thread local.

@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2024

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

wesleywiser
wesleywiser approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for FreeBSD and NetBSD seem fine to me. I know we also have DragonFlyBSD and OpenBSD in tree. Does it make sense to change those as well at this time?

@wesleywiser wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2024
@devnexen
Copy link
Contributor Author

openbsd does not support tls (yet), however dragonflybsd seems to.

@devnexen devnexen force-pushed the update_bsd_compiler_base_specs branch from 44b12a0 to dec4740 Compare January 22, 2024 17:10
@wesleywiser
Copy link
Member

Awesome, thanks @devnexen!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2024

📌 Commit dec4740 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#120188 - devnexen:update_bsd_compiler_base_…
d8e8a59 
…specs, r=wesleywiser

compiler: update freebsd and netbsd base specs.

both support thread local.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 22, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2024
@bors
Auto merge of rust-lang#120245 - matthiaskrgr:rollup-sokdxy1, r=matth…
d7e3647 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119664 (Fix tty detection for msys2's `/dev/ptmx`)
 - rust-lang#120104 (never_patterns: Count `!` bindings as diverging)
 - rust-lang#120109 (Move cmath into `sys`)
 - rust-lang#120143 (Consolidate logic around resolving built-in coroutine trait impls)
 - rust-lang#120159 (Track `verbose` and `verbose_internals`)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120216 (Fix a `trimmed_def_paths` assertion failure.)
 - rust-lang#120220 (Document `Token{Stream,Tree}::Display` more thoroughly.)
 - rust-lang#120233 (Revert stabilization of trait_upcasting feature)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
may have failed in #120245 (comment) ?

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2024
@rustbot rustbot added the O-unix Operating system: Unix-like label Jan 22, 2024
@wesleywiser
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 23, 2024

📌 Commit ed4b99a has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2024
fmease added a commit to fmease/rust that referenced this pull request Jan 23, 2024
@fmease
Rollup merge of rust-lang#120188 - devnexen:update_bsd_compiler_base_…
9c28877 
…specs, r=wesleywiser

compiler: update freebsd and netbsd base specs.

both support thread local.
@fmease fmease mentioned this pull request Jan 23, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#120271 - fmease:rollup-nbm2e8h, r=fmease
8a676e9 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#119028 (Add more weirdness to weird-exprs.rs)
 - rust-lang#119805 (Suggest array::from_fn for array initialization)
 - rust-lang#120124 (Split assembly tests for ELF and MachO)
 - rust-lang#120177 (Remove duplicate dependencies for rustc)
 - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120201 (Bump some deps with syn 1.0 dependencies)
 - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies)
 - rust-lang#120244 (Use `Self` in `NonZero*` implementations.)
 - rust-lang#120246 (Re-add estebank to review rotation)
 - rust-lang#120252 (rename `RawTy` to `LoweredTy`)
 - rust-lang#120255 (correct my mailmap entry)
 - rust-lang#120270 (A bunch of random modifications)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#120271 - fmease:rollup-nbm2e8h, r=fmease
1f09e7d 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#119028 (Add more weirdness to weird-exprs.rs)
 - rust-lang#119805 (Suggest array::from_fn for array initialization)
 - rust-lang#120124 (Split assembly tests for ELF and MachO)
 - rust-lang#120177 (Remove duplicate dependencies for rustc)
 - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120201 (Bump some deps with syn 1.0 dependencies)
 - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies)
 - rust-lang#120244 (Use `Self` in `NonZero*` implementations.)
 - rust-lang#120246 (Re-add estebank to review rotation)
 - rust-lang#120252 (rename `RawTy` to `LoweredTy`)
 - rust-lang#120255 (correct my mailmap entry)
 - rust-lang#120270 (A bunch of random modifications)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jan 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#120281 - fmease:rollup-9nxail8, r=fmease
5d3d347 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#119028 (Add more weirdness to weird-exprs.rs)
 - rust-lang#119805 (Suggest array::from_fn for array initialization)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies)
 - rust-lang#120244 (Use `Self` in `NonZero*` implementations.)
 - rust-lang#120246 (Re-add estebank to review rotation)
 - rust-lang#120252 (rename `RawTy` to `LoweredTy`)
 - rust-lang#120255 (correct my mailmap entry)
 - rust-lang#120270 (A bunch of random modifications)
 - rust-lang#120280 (Move condition enabling the pass to `is_enabled`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1e5ec4d into rust-lang:master Jan 23, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@rust-timer
Unrolled build for rust-lang#120188
e57847b 
Rollup merge of rust-lang#120188 - devnexen:update_bsd_compiler_base_specs, r=wesleywiser

compiler: update freebsd and netbsd base specs.

both support thread local.
@RalfJung RalfJung mentioned this pull request Jan 24, 2024
Closed
@ryanavella ryanavella mentioned this pull request Jan 27, 2024
Closed
@snowkat snowkat mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @rustbot @wesleywiser @bors @matthiaskrgr