For E0223, suggest associated functions that are similar to the path #120632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
oli-obk
reviewed
Feb 5, 2024
oli-obk
requested changes
Feb 5, 2024
Comment on lines
1397
to
1402
| if if let Some(ty_def_id) = qself_ty.ty_def_id() | ||
| && let Ok([inherent_impl]) = tcx.inherent_impls(ty_def_id) | ||
| && let Some(ty::AssocItem { kind: ty::AssocKind::Fn, .. }) = tcx | ||
| .associated_items(inherent_impl) | ||
| .filter_by_name_unhygienic(Symbol::intern(&name)) | ||
| .next() |
There was a problem hiding this comment.
Maybe use something like the method resolution logic to find the method, even if it's hidden behind derefs.
There was a problem hiding this comment.
rustbot
added
S-waiting-on-author
trevyn
changed the title
|
@oli-obk I moved everything into a helper function and removed the |
rustbot
added
S-waiting-on-review
|
Oh... yea, there's no good way to invoke that from here :/ I guess we'll miss out on some cases, but get the usual ones. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2024
…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#120520 (Some cleanups around diagnostic levels.) - rust-lang#120575 (Simplify codegen diagnostic handling) - rust-lang#120597 (Suggest `[tail @ ..]` on `[..tail]` and `[...tail]` where `tail` is unresolved) - rust-lang#120602 (rustc_monomorphize: fix outdated comment in partition) - rust-lang#120609 (hir: Stop keeping prefixes for most of `use` list stems) - rust-lang#120631 (Emit a diagnostic for invalid target options) - rust-lang#120632 (For E0223, suggest associated functions that are similar to the path) - rust-lang#120670 (cleanup effect var handling) - rust-lang#120673 (rustc_metadata: fix typo) - rust-lang#120683 (miri: fix ICE with symbolic alignment check on extern static) - rust-lang#120690 (Remove b-naber from the compiler review rotation) - rust-lang#120713 (Make async closures test use async bound modifier) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2024
Rollup merge of rust-lang#120632 - trevyn:issue-109195, r=oli-obk For E0223, suggest associated functions that are similar to the path e.g. for `String::from::utf8`, suggest `String::from_utf8` Closes rust-lang#109195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. for
String::from::utf8, suggestString::from_utf8Closes #109195