Continue compilation after check_mod_type_wf errors #120847
Conversation
|
rustbot has assigned @compiler-errors. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
track_errors9
branch
from
ea593a8 to
3cf7e0e
Compare
| @@ -516,11 +516,9 @@ impl<'a, 'tcx> ConfirmContext<'a, 'tcx> { | |||
| .report_mismatched_types(&cause, method_self_ty, self_ty, terr) | |||
| .emit(); | |||
| } else { | |||
| span_bug!( | |||
| self.dcx().span_delayed_bug( | |||
There was a problem hiding this comment.
what specifically is this for?
having hit this when refactoring method autoderef stuff, reasonably worried this will cause an ice later lol
There was a problem hiding this comment.
will hit that in default mode on the method call in main (during typeck).
I guess I could try to see if I can poison whatever emits the error in get and then check that in typeck.
There was a problem hiding this comment.
I changed it to an error! plus has_errors().unwrap(), meaning we won't ever silently eat it, and if there were no errors we'll escalate to an ICE.
|
☔ The latest upstream changes (presumably #120862) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
track_errors9
branch
from
3cf7e0e to
7bf38c7
Compare
|
☔ The latest upstream changes (presumably #120903) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
track_errors9
branch
from
7bf38c7 to
6c70bf6
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
…errors Continue compilation after check_mod_type_wf errors The ICEs fixed here were probably reachable through const eval gymnastics before, but now they are easily reachable without that, too. The new errors are often bugfixes, where useful errors were missing, because they were reported after the early abort. In other cases sometimes they are just duplication of already emitted errors, which won't be user-visible due to deduplication. fixes rust-lang#120860
…errors Continue compilation after check_mod_type_wf errors The ICEs fixed here were probably reachable through const eval gymnastics before, but now they are easily reachable without that, too. The new errors are often bugfixes, where useful errors were missing, because they were reported after the early abort. In other cases sometimes they are just duplication of already emitted errors, which won't be user-visible due to deduplication. fixes rust-lang#120860
Rollup of 6 pull requests Successful merges: - rust-lang#120486 (Use generic `NonZero` internally.) - rust-lang#120500 (Implement intrinsics with fallback bodies) - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety) - rust-lang#120563 (Make `NonZero::get` generic.) - rust-lang#120847 (Continue compilation after check_mod_type_wf errors) - rust-lang#120959 (Remove good path delayed bugs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
oli-obk
force-pushed
the
track_errors9
branch
from
6c70bf6 to
6e3082d
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (ee9c7c9): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 635.176s -> 636.575s (0.22%) |
The ICEs fixed here were probably reachable through const eval gymnastics before, but now they are easily reachable without that, too.
The new errors are often bugfixes, where useful errors were missing, because they were reported after the early abort. In other cases sometimes they are just duplication of already emitted errors, which won't be user-visible due to deduplication.
fixes #120860