-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make most bootstrap step types !Copy #121570
Conversation
r? @clubby789 rustbot has assigned @clubby789. Use r? to explicitly pick a reviewer |
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
This makes all bootstrap types except for `Compiler` and `TargetSelection` `!Copy`. This makes it easier to modify them by adding !Copy types in the future and comes at no cost of code clarity, the impls were completely unused.
@bors r+ rollup |
(commenting here even though I've already said this elsewhere)
This is a nice cleanup and I'm happy to see this PR, but what I wanted was a non-Copy |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119590 (Stabilize `cfg_target_abi`) - rust-lang#120805 (make non-PartialEq-typed consts as patterns a hard error) - rust-lang#121060 (Add newtypes for bool fields/params/return types) - rust-lang#121284 (Add test cases for inlining compiler-private items) - rust-lang#121324 (pattern_analysis: factor out unspecialization) - rust-lang#121409 (Prevent cycle in implied predicates computation) - rust-lang#121513 (Fix sgx unit test compilation) - rust-lang#121570 (Make most bootstrap step types !Copy) - rust-lang#121586 (Don't use `unwrap()` in `ArrayIntoIter` lint when typeck fails) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#121570 - Nilstrieb:!copy, r=clubby789 Make most bootstrap step types !Copy This makes all bootstrap types except for `Compiler` and `TargetSelection` `!Copy`. This makes it easier to modify them by adding !Copy types in the future, something that `@saethlin` has complained about before, and comes at no cost of code clarity, the impls were completely unused. Making `Compiler` and `TargetSelection` `!Copy` (which would allow getting rid of interning) is highly nontrivial as they are used and copied **all over the place**. This should hopefully get most of the benefits.
This makes all bootstrap types except for
Compiler
andTargetSelection
!Copy
. This makes it easier to modify them by adding !Copy types in the future, something that @saethlin has complained about before, and comes at no cost of code clarity, the impls were completely unused.Making
Compiler
andTargetSelection
!Copy
(which would allow getting rid of interning) is highly nontrivial as they are used and copied all over the place. This should hopefully get most of the benefits.