-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more intrinsics to rustc_intrinsic #122037
Conversation
r? @Nilstrieb rustbot has assigned @Nilstrieb. Use r? to explicitly pick a reviewer |
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
bcd98af
to
7669f57
Compare
☔ The latest upstream changes (presumably #122045) made this pull request unmergeable. Please resolve the merge conflicts. |
7669f57
to
bbc88ef
Compare
☔ The latest upstream changes (presumably #122241) made this pull request unmergeable. Please resolve the merge conflicts. |
bbc88ef
to
095eb69
Compare
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
@rustbot author Need to add the abort, otherwise screwing up and invoking the body causes UB |
This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a The Miri subtree was changed cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_gcc |
@rustbot ready |
at that point I'd prefer to use the Unreachable terminator in this PR or add the Abort terminator in a separate PR (I'm inclined to use the Unreachable terminator since that should still often result in crashes and adding a new terminator seems like a lot of stuff for just the intrinsics, unless there are other use cases for it) |
I removed the |
4b64211
to
ff12979
Compare
@bors r+ |
☔ The latest upstream changes (presumably #122690) made this pull request unmergeable. Please resolve the merge conflicts. |
…kends implementing it
…e actual overrides in codegen
ff12979
to
a8f71cf
Compare
@bors r=Nilstrieb |
☀️ Test successful - checks-actions |
Finished benchmarking commit (200e3f7): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.996s -> 669.309s (-0.10%) |
cc #63585