Simplify trim-paths feature by merging all debuginfo options together

[Urgau]

This PR simplifies the trim-paths feature by merging all debuginfo options together, as described in #111540 (comment).

And also do some correctness fixes found during the review.

cc @weihanglo
r? @michaelwoerister

[michaelwoerister]

Thanks for the PR, @Urgau! I think we'll do this, but since this is deviating from the accepted RFC, I want to find out what the procedure is here.

[Urgau]

I think we'll do this, but since this is deviating from the accepted RFC, I want to find out what the procedure is here.

I'm not aware of such procedure. Our RFCs are not normative and it's common to diverged from them in the implementation and experimentation phase.

I would say that as long as we respect the goal of the RFC (as defined in the Summary and Motivation section of the RFC), we are good to adapt the implementation to achieve that goal, particularly here since we are adapting the implementation to match the reality (ie. the current limitation of the tooling and LLVM).

There is also nothing here that would prevent re-introducing the lost options in the future.

So I think we are go to go.

[michaelwoerister]

I actually remembered a similar case where I asked about the proceduce:
https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Add.20-C.20dlltool.20for.20raw-dylibs.3F

Let's make sure we document what we are doing on the tracking issue an mention it in the stabilization FCP, then we should indeed be good.

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

[rustbot]

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in run-make tests.

cc @jieyouxu

Some changes occurred in coverage instrumentation.

cc @Zalathar

[bors]

☔ The latest upstream changes (presumably #122713) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

[bors]

☔ The latest upstream changes (presumably #123166) made this pull request unmergeable. Please resolve the merge conflicts.

[Urgau]

Rebased (and fix some typos).

@rustbot ready

[michaelwoerister]

Thanks!

@bors r+

[bors]

📌 Commit fefb8f1 has been approved by michaelwoerister

It is now in the queue for this repository.

[bors]

⌛ Testing commit fefb8f1 with merge 685927a...

[bors]

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 685927a to master...

[rust-timer]

Finished benchmarking commit (685927a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.043s -> 667.959s (-0.01%)
Artifact size: 315.85 MiB -> 315.84 MiB (-0.00%)