-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag_for_variant
query
#122784
Merged
Merged
Add tag_for_variant
query
#122784
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
193 changes: 193 additions & 0 deletions
193
compiler/rustc_const_eval/src/const_eval/dummy_machine.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,193 @@ | ||
use crate::interpret::{self, HasStaticRootDefId, ImmTy, Immediate, InterpCx, PointerArithmetic}; | ||
use rustc_middle::mir::interpret::{AllocId, ConstAllocation, InterpResult}; | ||
use rustc_middle::mir::*; | ||
use rustc_middle::query::TyCtxtAt; | ||
use rustc_middle::ty; | ||
use rustc_middle::ty::layout::TyAndLayout; | ||
use rustc_span::def_id::DefId; | ||
|
||
/// Macro for machine-specific `InterpError` without allocation. | ||
/// (These will never be shown to the user, but they help diagnose ICEs.) | ||
pub macro throw_machine_stop_str($($tt:tt)*) {{ | ||
// We make a new local type for it. The type itself does not carry any information, | ||
// but its vtable (for the `MachineStopType` trait) does. | ||
#[derive(Debug)] | ||
struct Zst; | ||
// Printing this type shows the desired string. | ||
impl std::fmt::Display for Zst { | ||
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
write!(f, $($tt)*) | ||
} | ||
} | ||
|
||
impl rustc_middle::mir::interpret::MachineStopType for Zst { | ||
fn diagnostic_message(&self) -> rustc_errors::DiagMessage { | ||
self.to_string().into() | ||
} | ||
|
||
fn add_args( | ||
self: Box<Self>, | ||
_: &mut dyn FnMut(rustc_errors::DiagArgName, rustc_errors::DiagArgValue), | ||
) {} | ||
} | ||
throw_machine_stop!(Zst) | ||
}} | ||
|
||
pub struct DummyMachine; | ||
|
||
impl HasStaticRootDefId for DummyMachine { | ||
fn static_def_id(&self) -> Option<rustc_hir::def_id::LocalDefId> { | ||
None | ||
} | ||
} | ||
|
||
impl<'mir, 'tcx: 'mir> interpret::Machine<'mir, 'tcx> for DummyMachine { | ||
interpret::compile_time_machine!(<'mir, 'tcx>); | ||
type MemoryKind = !; | ||
const PANIC_ON_ALLOC_FAIL: bool = true; | ||
|
||
#[inline(always)] | ||
fn enforce_alignment(_ecx: &InterpCx<'mir, 'tcx, Self>) -> bool { | ||
false // no reason to enforce alignment | ||
} | ||
|
||
fn enforce_validity(_ecx: &InterpCx<'mir, 'tcx, Self>, _layout: TyAndLayout<'tcx>) -> bool { | ||
false | ||
} | ||
|
||
fn before_access_global( | ||
_tcx: TyCtxtAt<'tcx>, | ||
_machine: &Self, | ||
_alloc_id: AllocId, | ||
alloc: ConstAllocation<'tcx>, | ||
_static_def_id: Option<DefId>, | ||
is_write: bool, | ||
) -> InterpResult<'tcx> { | ||
if is_write { | ||
throw_machine_stop_str!("can't write to global"); | ||
} | ||
|
||
// If the static allocation is mutable, then we can't const prop it as its content | ||
// might be different at runtime. | ||
if alloc.inner().mutability.is_mut() { | ||
throw_machine_stop_str!("can't access mutable globals in ConstProp"); | ||
} | ||
|
||
Ok(()) | ||
} | ||
|
||
fn find_mir_or_eval_fn( | ||
_ecx: &mut InterpCx<'mir, 'tcx, Self>, | ||
_instance: ty::Instance<'tcx>, | ||
_abi: rustc_target::spec::abi::Abi, | ||
_args: &[interpret::FnArg<'tcx, Self::Provenance>], | ||
_destination: &interpret::MPlaceTy<'tcx, Self::Provenance>, | ||
_target: Option<BasicBlock>, | ||
_unwind: UnwindAction, | ||
) -> interpret::InterpResult<'tcx, Option<(&'mir Body<'tcx>, ty::Instance<'tcx>)>> { | ||
unimplemented!() | ||
} | ||
|
||
fn panic_nounwind( | ||
_ecx: &mut InterpCx<'mir, 'tcx, Self>, | ||
_msg: &str, | ||
) -> interpret::InterpResult<'tcx> { | ||
unimplemented!() | ||
} | ||
|
||
fn call_intrinsic( | ||
_ecx: &mut InterpCx<'mir, 'tcx, Self>, | ||
_instance: ty::Instance<'tcx>, | ||
_args: &[interpret::OpTy<'tcx, Self::Provenance>], | ||
_destination: &interpret::MPlaceTy<'tcx, Self::Provenance>, | ||
_target: Option<BasicBlock>, | ||
_unwind: UnwindAction, | ||
) -> interpret::InterpResult<'tcx> { | ||
unimplemented!() | ||
} | ||
|
||
fn assert_panic( | ||
_ecx: &mut InterpCx<'mir, 'tcx, Self>, | ||
_msg: &rustc_middle::mir::AssertMessage<'tcx>, | ||
_unwind: UnwindAction, | ||
) -> interpret::InterpResult<'tcx> { | ||
unimplemented!() | ||
} | ||
|
||
fn binary_ptr_op( | ||
ecx: &InterpCx<'mir, 'tcx, Self>, | ||
bin_op: BinOp, | ||
left: &interpret::ImmTy<'tcx, Self::Provenance>, | ||
right: &interpret::ImmTy<'tcx, Self::Provenance>, | ||
) -> interpret::InterpResult<'tcx, (ImmTy<'tcx, Self::Provenance>, bool)> { | ||
use rustc_middle::mir::BinOp::*; | ||
Ok(match bin_op { | ||
Eq | Ne | Lt | Le | Gt | Ge => { | ||
// Types can differ, e.g. fn ptrs with different `for`. | ||
assert_eq!(left.layout.abi, right.layout.abi); | ||
let size = ecx.pointer_size(); | ||
// Just compare the bits. ScalarPairs are compared lexicographically. | ||
// We thus always compare pairs and simply fill scalars up with 0. | ||
// If the pointer has provenance, `to_bits` will return `Err` and we bail out. | ||
let left = match **left { | ||
Immediate::Scalar(l) => (l.to_bits(size)?, 0), | ||
Immediate::ScalarPair(l1, l2) => (l1.to_bits(size)?, l2.to_bits(size)?), | ||
Immediate::Uninit => panic!("we should never see uninit data here"), | ||
}; | ||
let right = match **right { | ||
Immediate::Scalar(r) => (r.to_bits(size)?, 0), | ||
Immediate::ScalarPair(r1, r2) => (r1.to_bits(size)?, r2.to_bits(size)?), | ||
Immediate::Uninit => panic!("we should never see uninit data here"), | ||
}; | ||
let res = match bin_op { | ||
Eq => left == right, | ||
Ne => left != right, | ||
Lt => left < right, | ||
Le => left <= right, | ||
Gt => left > right, | ||
Ge => left >= right, | ||
_ => bug!(), | ||
}; | ||
(ImmTy::from_bool(res, *ecx.tcx), false) | ||
} | ||
|
||
// Some more operations are possible with atomics. | ||
// The return value always has the provenance of the *left* operand. | ||
Add | Sub | BitOr | BitAnd | BitXor => { | ||
throw_machine_stop_str!("pointer arithmetic is not handled") | ||
} | ||
|
||
_ => span_bug!(ecx.cur_span(), "Invalid operator on pointers: {:?}", bin_op), | ||
}) | ||
} | ||
|
||
fn expose_ptr( | ||
_ecx: &mut InterpCx<'mir, 'tcx, Self>, | ||
_ptr: interpret::Pointer<Self::Provenance>, | ||
) -> interpret::InterpResult<'tcx> { | ||
unimplemented!() | ||
} | ||
|
||
fn init_frame_extra( | ||
_ecx: &mut InterpCx<'mir, 'tcx, Self>, | ||
_frame: interpret::Frame<'mir, 'tcx, Self::Provenance>, | ||
) -> interpret::InterpResult< | ||
'tcx, | ||
interpret::Frame<'mir, 'tcx, Self::Provenance, Self::FrameExtra>, | ||
> { | ||
unimplemented!() | ||
} | ||
|
||
fn stack<'a>( | ||
_ecx: &'a InterpCx<'mir, 'tcx, Self>, | ||
) -> &'a [interpret::Frame<'mir, 'tcx, Self::Provenance, Self::FrameExtra>] { | ||
// Return an empty stack instead of panicking, as `cur_span` uses it to evaluate constants. | ||
&[] | ||
} | ||
|
||
fn stack_mut<'a>( | ||
_ecx: &'a mut InterpCx<'mir, 'tcx, Self>, | ||
) -> &'a mut Vec<interpret::Frame<'mir, 'tcx, Self::Provenance, Self::FrameExtra>> { | ||
unimplemented!() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ use either::{Left, Right}; | |
use rustc_hir::def::DefKind; | ||
use rustc_middle::mir::interpret::{AllocId, ErrorHandled, InterpErrorInfo}; | ||
use rustc_middle::mir::{self, ConstAlloc, ConstValue}; | ||
use rustc_middle::query::TyCtxtAt; | ||
use rustc_middle::query::{Key, TyCtxtAt}; | ||
use rustc_middle::traits::Reveal; | ||
use rustc_middle::ty::layout::LayoutOf; | ||
use rustc_middle::ty::print::with_no_trimmed_paths; | ||
|
@@ -243,6 +243,24 @@ pub(crate) fn turn_into_const_value<'tcx>( | |
op_to_const(&ecx, &mplace.into(), /* for diagnostics */ false) | ||
} | ||
|
||
/// Computes the tag (if any) for a given type and variant. | ||
#[instrument(skip(tcx), level = "debug")] | ||
pub fn tag_for_variant_provider<'tcx>( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't really an "eval" query, so |
||
tcx: TyCtxt<'tcx>, | ||
(ty, variant_index): (Ty<'tcx>, abi::VariantIdx), | ||
) -> Option<ty::ScalarInt> { | ||
assert!(ty.is_enum()); | ||
|
||
let ecx = InterpCx::new( | ||
RalfJung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
tcx, | ||
ty.default_span(tcx), | ||
ty::ParamEnv::reveal_all(), | ||
crate::const_eval::DummyMachine, | ||
); | ||
|
||
ecx.tag_for_variant(ty, variant_index).unwrap().map(|(tag, _tag_field)| tag) | ||
} | ||
|
||
#[instrument(skip(tcx), level = "debug")] | ||
pub fn eval_to_const_value_raw_provider<'tcx>( | ||
tcx: TyCtxt<'tcx>, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was extracted wholesale from
compiler/rustc_mir_transform/src/dataflow_const_prop.rs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great, I wanted this to be moved for a while. :)