Portable SIMD subtree update #122905

dpaoliello · 2024-03-22T20:31:49Z

Syncs nightly to the latest changes from rust-lang/portable-simd

r? @calebzulawski

Remove redundant imports

Fix build error on big endian aarch64

fix build error on AVX-512

…, cos).

feat: add SIMD float math functions (exp, exp2, log, log2, log10, sin…

Test StdFloat

Add arm64ec support

Add support for masked loads & stores

rustbot · 2024-03-22T20:31:56Z

Failed to set assignee to calebzulawski: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot · 2024-03-22T20:31:57Z

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

calebzulawski · 2024-03-22T21:09:14Z

Can you combine your two additional commits?

dpaoliello · 2024-03-22T21:11:37Z

Can you combine your two additional commits?

Done

workingjubilee

I apologize, I believe the rust-lang/rust to rust-lang/portable-simd direction should happen first? I believe that is the only reason this is breaking tests.

library/portable-simd/crates/core_simd/src/vector.rs

dpaoliello · 2024-03-22T21:46:35Z

I apologize, I believe the rust-lang/rust to rust-lang/portable-simd direction should happen first? I believe that is the only reason this is breaking tests.

There were no changes in the rust-lang/rust portable-simd. The doc failures were added 2 weeks ago (rust-lang/portable-simd@4f0ba1a), and the Try* traits were previously imported, but then removed in a cleanup last month (rust-lang/portable-simd@bb4bba5)

dpaoliello · 2024-03-22T23:10:36Z

Any further changes requested? Otherwise, can someone please put this in the queue?

workingjubilee · 2024-03-22T23:15:01Z

Ah, is there any chance you could make it so this was based on portable-simd tip-of-tree instead of having 6736d7b be an empty commit when synced back? ^^;

workingjubilee · 2024-03-22T23:29:11Z

This should go in alone when it does go.

@bors rollup=never p=1

…table-simd-2024-03-22

dpaoliello · 2024-03-23T00:08:18Z

Ah, is there any chance you could make it so this was based on portable-simd tip-of-tree instead of having 6736d7b be an empty commit when synced back? ^^;

Done

workingjubilee · 2024-03-23T00:11:17Z

Thanks! Sorry about that, I know this gets to be a huge pain in the ass. ^^;
In we go!

@bors r+

bors · 2024-03-23T00:11:19Z

📌 Commit 9e0ec25 has been approved by workingjubilee

It is now in the queue for this repository.

library/portable-simd/crates/std_float/src/lib.rs

add support for missing SIMD float intrinsics These are being exposed by `core::simd` with rust-lang/rust#122905.

add support for missing SIMD float intrinsics These are being exposed by `core::simd` with rust-lang#122905.

bors · 2024-03-24T00:02:17Z

⌛ Testing commit 9e0ec25 with merge 9b8d12c...

bors · 2024-03-24T02:01:50Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 9b8d12c to master...

rust-timer · 2024-03-24T03:16:07Z

Finished benchmarking commit (9b8d12c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.644s -> 669.289s (-0.05%)
Artifact size: 314.97 MiB -> 315.03 MiB (0.02%)

add support for missing SIMD float intrinsics These are being exposed by `core::simd` with rust-lang#122905.

…3-22, r=workingjubilee Portable SIMD subtree update Syncs nightly to the latest changes from rust-lang/portable-simd r? `@calebzulawski`

Import the 2021 prelude in the core crate The `core` crate currently imports the v1 prelude https://github.com/rust-lang/rust/blob/b3df0d7e5ef5f7dbeeca3fb289c65680ad013f87/library/core/src/lib.rs#L285-L287 This recently caused an issue when updating the `portable-simd` subtree since it was using a trait that was added to the 2021 prelude: rust-lang#122905 (comment) To make it easier to have a consistent build environment for subtrees and submodules that get included in `core`, we will now import the 2021 prelude into `core`. Fixes rust-lang#122912 r? `@Nilstrieb`

Rollup merge of rust-lang#123042 - dpaoliello:prelude, r=Nilstrieb Import the 2021 prelude in the core crate The `core` crate currently imports the v1 prelude https://github.com/rust-lang/rust/blob/b3df0d7e5ef5f7dbeeca3fb289c65680ad013f87/library/core/src/lib.rs#L285-L287 This recently caused an issue when updating the `portable-simd` subtree since it was using a trait that was added to the 2021 prelude: rust-lang#122905 (comment) To make it easier to have a consistent build environment for subtrees and submodules that get included in `core`, we will now import the 2021 prelude into `core`. Fixes rust-lang#122912 r? `@Nilstrieb`

Import the 2021 prelude in the core crate The `core` crate currently imports the v1 prelude https://github.com/rust-lang/rust/blob/b3df0d7e5ef5f7dbeeca3fb289c65680ad013f87/library/core/src/lib.rs#L285-L287 This recently caused an issue when updating the `portable-simd` subtree since it was using a trait that was added to the 2021 prelude: rust-lang/rust#122905 (comment) To make it easier to have a consistent build environment for subtrees and submodules that get included in `core`, we will now import the 2021 prelude into `core`. Fixes #122912 r? `@Nilstrieb`

taiki-e and others added 18 commits February 22, 2024 17:09

Remove redundant imports

bb4bba5

Merge pull request rust-lang#397 from taiki-e/imports

8c786f3

Remove redundant imports

Fix build error on big endian aarch64

6ce3ab7

Merge pull request rust-lang#396 from taiki-e/aarch64-big

94f4f68

Fix build error on big endian aarch64

add stdarch_x86_avx512 feature flag for AVX-512-supporting architectures

18de239

Merge pull request rust-lang#398 from AquaEBM/avx512-feature-flag

fbc9efa

fix build error on AVX-512

feat: add SIMD float math functions (exp, exp2, log, log2, log10, sin…

499a53d

…, cos).

Merge pull request rust-lang#400 from avhz/master

eea6f77

feat: add SIMD float math functions (exp, exp2, log, log2, log10, sin…

Test std_float

5b5b259

Update docs

e5d5006

Fix formatting

bcedde5

Fix wasm tests

2f062b8

Attempt to avoid LLVM error

278eb28

Merge pull request rust-lang#401 from rust-lang/std_float_improvements

5794c83

Test StdFloat

Add arm64ec support

ca4033f

Add support for masked loads & stores

4f0ba1a

Merge pull request rust-lang#404 from dpaoliello/arm64ec

6aeff2e

Add arm64ec support

Merge pull request rust-lang#399 from farnoy/masked-load-store-simple

50e8ae8

Add support for masked loads & stores

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2024

This comment has been minimized.

Sign in to view

dpaoliello force-pushed the sync-portable-simd-2024-03-22 branch from 1b413d5 to 08bd6e0 Compare March 22, 2024 21:11

workingjubilee reviewed Mar 22, 2024

View reviewed changes

library/portable-simd/crates/core_simd/src/vector.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

workingjubilee reviewed Mar 22, 2024

View reviewed changes

library/portable-simd/crates/core_simd/src/vector.rs Outdated Show resolved Hide resolved

dpaoliello force-pushed the sync-portable-simd-2024-03-22 branch from 08bd6e0 to b4c3ad1 Compare March 22, 2024 21:35

Merge commit 'cff979eec1ac0473fc4960ee6cde462c6aeda824' into sync-por…

9e0ec25

…table-simd-2024-03-22

dpaoliello force-pushed the sync-portable-simd-2024-03-22 branch from 6736d7b to 9e0ec25 Compare March 23, 2024 00:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2024

workingjubilee self-assigned this Mar 23, 2024

workingjubilee added the subtree-sync PR updates a subtree (miri, clippy, etc). Ignored by no-merges check label Mar 23, 2024

RalfJung reviewed Mar 23, 2024

View reviewed changes

library/portable-simd/crates/std_float/src/lib.rs Show resolved Hide resolved

RalfJung mentioned this pull request Mar 23, 2024

add support for missing SIMD float intrinsics rust-lang/miri#3396

Merged

bors added a commit to rust-lang/miri that referenced this pull request Mar 23, 2024

Auto merge of #3396 - RalfJung:simd-float, r=RalfJung

33e93f7

add support for missing SIMD float intrinsics These are being exposed by `core::simd` with rust-lang/rust#122905.

RalfJung pushed a commit to RalfJung/rust that referenced this pull request Mar 23, 2024

Auto merge of rust-lang#3396 - RalfJung:simd-float, r=RalfJung

e19cc5e

add support for missing SIMD float intrinsics These are being exposed by `core::simd` with rust-lang#122905.

RalfJung mentioned this pull request Mar 23, 2024

Miri subtree update #122952

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 24, 2024

bors merged commit 9b8d12c into rust-lang:master Mar 24, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Mar 24, 2024

RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024

Auto merge of rust-lang#3396 - RalfJung:simd-float, r=RalfJung

9540d7d

add support for missing SIMD float intrinsics These are being exposed by `core::simd` with rust-lang#122905.

dpaoliello mentioned this pull request Mar 25, 2024

Import the 2021 prelude in the core crate #123042

Merged

cuviper mentioned this pull request Mar 28, 2024

When is it available in the stable version of rust? rust-lang/portable-simd#409

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Portable SIMD subtree update #122905

Portable SIMD subtree update #122905

dpaoliello commented Mar 22, 2024

rustbot commented Mar 22, 2024

rustbot commented Mar 22, 2024

This comment has been minimized.

calebzulawski commented Mar 22, 2024

dpaoliello commented Mar 22, 2024

workingjubilee left a comment

This comment has been minimized.

dpaoliello commented Mar 22, 2024

dpaoliello commented Mar 22, 2024

workingjubilee commented Mar 22, 2024

workingjubilee commented Mar 22, 2024

dpaoliello commented Mar 23, 2024

workingjubilee commented Mar 23, 2024

bors commented Mar 23, 2024

bors commented Mar 24, 2024

bors commented Mar 24, 2024

rust-timer commented Mar 24, 2024

Portable SIMD subtree update #122905

Portable SIMD subtree update #122905

Conversation

dpaoliello commented Mar 22, 2024

rustbot commented Mar 22, 2024

rustbot commented Mar 22, 2024

This comment has been minimized.

calebzulawski commented Mar 22, 2024

dpaoliello commented Mar 22, 2024

workingjubilee left a comment

Choose a reason for hiding this comment

This comment has been minimized.

dpaoliello commented Mar 22, 2024

dpaoliello commented Mar 22, 2024

workingjubilee commented Mar 22, 2024

workingjubilee commented Mar 22, 2024

dpaoliello commented Mar 23, 2024

workingjubilee commented Mar 23, 2024

bors commented Mar 23, 2024

bors commented Mar 24, 2024

bors commented Mar 24, 2024

rust-timer commented Mar 24, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size