Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log BOLT args in bootstrap rustc shim #123189

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Log BOLT args in bootstrap rustc shim #123189

merged 1 commit into from
Mar 31, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 29, 2024

Before, the BOLT argument would not be logged, because it was only added after the logging has happened.

Found by @RalfJung here.

@Kobzol Kobzol mentioned this pull request Mar 29, 2024
Merged
@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 29, 2024
@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit a4087b7 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
@RalfJung
Copy link
Member

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Mar 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#123264 - matthiaskrgr:rollup-smyy7j9, r=matth…
395f780 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#123189 (Log BOLT args in bootstrap `rustc` shim)
 - rust-lang#123211 (Stop calling visitors `V`)
 - rust-lang#123242 (pattern analysis: Require enum indices to be contiguous)
 - rust-lang#123260 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0928a54 into rust-lang:master Mar 31, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@rust-timer
Unrolled build for rust-lang#123189
e779ebe 
Rollup merge of rust-lang#123189 - Kobzol:rustc-shim-log, r=onur-ozkan

Log BOLT args in bootstrap `rustc` shim

Before, the BOLT argument would not be logged, because it was only added after the logging has happened.

Found by `@RalfJung` [here](rust-lang#116352 (comment)).
@Kobzol Kobzol deleted the rustc-shim-log branch March 31, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kobzol @rustbot @onur-ozkan @bors @RalfJung @albertlarsan68