-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mention heap allocation earlier in String docs #123270
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would find this slightly better if it was incorporated into the previous paragraph, to explain that the buffer is indeed what it owns. But at minimum it should distinguish that String is still just a lightweight "smart pointer" that manages a buffer and not the buffer per se.
Just a tiny addition. Helps with rust-lang#123263.
3895927
to
418535b
Compare
Oh yes that's much better! @bors r+ |
@bors rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (66de611): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.771s -> 667.526s (-0.04%) |
Just a tiny addition.
Helps with #123263.