Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention heap allocation earlier in String docs #123270

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

JaniM
Copy link
Contributor

@JaniM JaniM commented Mar 31, 2024

Just a tiny addition.

Helps with #123263.

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 31, 2024
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would find this slightly better if it was incorporated into the previous paragraph, to explain that the buffer is indeed what it owns. But at minimum it should distinguish that String is still just a lightweight "smart pointer" that manages a buffer and not the buffer per se.

library/alloc/src/string.rs Outdated Show resolved Hide resolved
@workingjubilee workingjubilee added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
@JaniM JaniM force-pushed the janim/string-alloc-doc branch from 3895927 to 418535b Compare March 31, 2024 21:05
@workingjubilee
Copy link
Member

Oh yes that's much better!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit 418535b has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2024
@workingjubilee
Copy link
Member

@bors rollup

@bors
Copy link
Contributor

bors commented Mar 31, 2024

⌛ Testing commit 418535b with merge 66de611...

@bors
Copy link
Contributor

bors commented Apr 1, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 66de611 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 1, 2024
@bors bors merged commit 66de611 into rust-lang:master Apr 1, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 1, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (66de611): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.771s -> 667.526s (-0.04%)
Artifact size: 315.70 MiB -> 315.67 MiB (-0.01%)

@JaniM JaniM deleted the janim/string-alloc-doc branch April 1, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants