Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Freeze bounds from sync::MutexArc #12336

Merged
merged 2 commits into from
Feb 18, 2014

Conversation

lilyball
Copy link
Contributor

With Rc no longer trying to statically prevent cycles (and thus no
longer using the Freeze bound), it seems appropriate to remove that
restriction from MutexArc as well.

Closes #9251.

@huonw
Copy link
Member

huonw commented Feb 17, 2014

Do you mean Rc rather than Gc?

With Rc no longer trying to statically prevent cycles (and thus no
longer using the Freeze bound), it seems appropriate to remove that
restriction from MutexArc as well.
@lilyball
Copy link
Contributor Author

@huonw Yes I did, thanks. Updated.

@alexcrichton
Copy link
Member

I am in favor of this, @brson, @pcwalton, objections?

@brson
Copy link
Contributor

brson commented Feb 17, 2014

👍

@sfackler
Copy link
Member

👍

This closes #9251.

bors added a commit that referenced this pull request Feb 18, 2014
With Rc no longer trying to statically prevent cycles (and thus no
longer using the Freeze bound), it seems appropriate to remove that
restriction from MutexArc as well.

Closes #9251.
@bors bors closed this Feb 18, 2014
@bors bors merged commit 449c34a into rust-lang:master Feb 18, 2014
@lilyball lilyball deleted the mutexarc-no-freeze branch March 25, 2014 02:24
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
fix: rust-lang#12267  type-mismatch when using equals w/ a trait bound
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 26, 2024
FIX(12243): redundant_guards

Fixed rust-lang#12243

changelog: Fix[`redundant_guards`]

I have made a correction so that no warning does  appear when y.is_empty() is used within a constant function as follows.

```rust
pub const fn const_fn(x: &str) {
    match x {
        // Shouldn't lint.
        y if y.is_empty() => {},
        _ => {},
    }
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify use of unsafe in extra::arc
6 participants