Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::net: adding unix_socket_exclbind feature for solaris/illumos. #123476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std::net: adding unix_socket_exclbind feature for solaris/illumos. #123476

wants to merge 1 commit into from
+117 −0

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 4, 2024 •
edited by Dylan-DPC
Loading

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-solaris Operating system: Solaris O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 4, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@devnexen devnexen force-pushed the std_net_solaris_exclbind branch 2 times, most recently from 72f141f to ec6cc6c Compare April 4, 2024 22:24
@devnexen devnexen marked this pull request as ready for review April 4, 2024 22:50
@devnexen
std::net: adding unix_socket_exclbind feature for solaris/illumos.
ec6cc6c 
allows to have a tigher control over the binding exclusivness of the
socket.
@Mark-Simulacrum
Copy link
Member

Can you file an ACP for this change?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2024
@devnexen devnexen mentioned this pull request Apr 5, 2024
Open
@devnexen
Copy link
Contributor Author

devnexen commented Apr 5, 2024

Sure thing.

@devnexen
Copy link
Contributor Author

devnexen commented Apr 5, 2024

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2024
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@devnexen
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2024
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2024
@Mark-Simulacrum
Copy link
Member

Please mark as ready only once/if the ACP has been accepted.

@bors
Copy link
Contributor

bors commented Feb 6, 2025

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
O-solaris Operating system: Solaris O-unix Operating system: Unix-like S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @rustbot @rust-log-analyzer @Mark-Simulacrum @bors