Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the experience of running Docker locally #123678

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Apr 9, 2024

When running locally, the absence of the GITHUB_STEP_SUMMARY environment variable will lead to the following error:

::endgroup::
./src/ci/docker/run.sh: line 349: : No such file or directory

I've also changed the output artifacts directory to obj/$image_name, allowing me to easily run all images locally. We always encounter various strange issues when modifying the test cases in the codegen directory.

r? Kobzol cc @saethlin

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 9, 2024
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! I want to improve the experience of running CI locally more in the future, to make it easier to reproduce our CI artifacts, this is a good start (and also an important fix).

src/ci/docker/run.sh Show resolved Hide resolved
@Kobzol
Copy link
Contributor

Kobzol commented Apr 16, 2024

@bors r+ rollup=never

Let's see if everything works fine on CI.

@bors
Copy link
Contributor

bors commented Apr 16, 2024

📌 Commit 86e939e has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@bors
Copy link
Contributor

bors commented Apr 17, 2024

⌛ Testing commit 86e939e with merge 6c6b302...

@bors
Copy link
Contributor

bors commented Apr 17, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 6c6b302 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 17, 2024
@bors bors merged commit 6c6b302 into rust-lang:master Apr 17, 2024
13 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 17, 2024
@DianQK DianQK deleted the docker-local branch April 17, 2024 08:49
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6c6b302): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.9% [-1.9%, -1.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [-1.9%, 2.1%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 678.091s -> 679.119s (0.15%)
Artifact size: 316.07 MiB -> 316.14 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants