-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the experience of running Docker locally #123678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! I want to improve the experience of running CI locally more in the future, to make it easier to reproduce our CI artifacts, this is a good start (and also an important fix).
@bors r+ rollup=never Let's see if everything works fine on CI. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6c6b302): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 678.091s -> 679.119s (0.15%) |
When running locally, the absence of the
GITHUB_STEP_SUMMARY
environment variable will lead to the following error:I've also changed the output artifacts directory to
obj/$image_name
, allowing me to easily run all images locally. We always encounter various strange issues when modifying the test cases in thecodegen
directory.r? Kobzol cc @saethlin