Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #124250

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Rollup of 3 pull requests #124250

merged 8 commits into from
Apr 22, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

matthiaskrgr and others added 8 commits April 21, 2024 22:00
@matthiaskrgr
add test for rust-lang#121413
28f60ff 
Fixes rust-lang#121413
@matthiaskrgr
add test for ice rust-lang#121463
751f662 
Fixes rust-lang#121463
@matthiaskrgr
add test for ICE caused by using feature(generic_const_exprs) rust-la…
a42adf2 
…ng#114463

Fixes rust-lang#114463
@workingjubilee
bootstrap: Promote some build_steps comments to docs
9470e05
@gurry
Add comma at one place in abs() documentation
f31e4ae
@matthiaskrgr
Rollup merge of rust-lang#124240 - matthiaskrgr:tests_sunday, r=compi…
3cd56f3 
…ler-errors

add a couple tests for fixed ICEs.

Fixes rust-lang#121413
Fixes rust-lang#121463
Fixes rust-lang#114463
@matthiaskrgr
Rollup merge of rust-lang#124245 - workingjubilee:bootstrap-some-doc-…
e4e660e 
…comments, r=onur-ozkan

bootstrap: Promote some build_steps comments to docs

No new content, just makes some comments readable when viewing the docs with `--document-private-items`.
@matthiaskrgr
Rollup merge of rust-lang#124246 - gurry:add-comma-in-abs-doc, r=jhpratt
c597ccf 
Add comma at one place in `abs()` documentation

As suggested  by ``@RalfJung`` here: rust-lang#124184 (comment)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 22, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Apr 22, 2024

📌 Commit c597ccf has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
@bors
Copy link
Contributor

bors commented Apr 22, 2024

⌛ Testing commit c597ccf with merge 290d792...

@bors
Copy link
Contributor

bors commented Apr 22, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 290d792 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2024
@bors bors merged commit 290d792 into rust-lang:master Apr 22, 2024
13 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 22, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#124240 add a couple tests for fixed ICEs. cb7a1bf60667f68012b1b311ecd1d31e5b6968b1 (link)
#124245 bootstrap: Promote some build_steps comments to docs 38ce5dd6627532371c989414687acb88776be38d (link)
#124246 Add comma at one place in abs() documentation 08a0a249a825f68b89c6b2c89dae365fef434a9d (link)

previous master: b3e117044c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (290d792): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.828s -> 671.419s (-0.06%)
Artifact size: 315.40 MiB -> 315.41 MiB (0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-b8tqsup branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @bors @rust-timer @rustbot @workingjubilee @gurry