Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove many #[macro_use] extern crate foo items #124511

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Remove many #[macro_use] extern crate foo items #124511

merged 10 commits into from
Apr 30, 2024

Conversation

nnethercote
Copy link
Contributor

This requires the addition of more use items, which often make the code more verbose. But they also make the code easier to read, because #[macro_use] obscures where macros are defined.

r? @fee1-dead

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

rustc_errors::translation was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

changes to the core type system

cc @compiler-errors, @lcnr

Some changes occurred in exhaustiveness checking

cc @Nadrieril

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred in check-cfg diagnostics

cc @Urgau

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in abstract_const.rs

cc @BoxyUwU

@nnethercote
Copy link
Contributor Author

Note: this doesn't remove all #[macro_use] extern crate items. There were some that would require a lot of extra use items, and I didn't have the patience to do those ones.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
fee1-dead
fee1-dead requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was 320 files to sift through. Some rambling on imports that you don't need to address, and a nit on comments. r=me afterwards.

compiler/rustc_ast_lowering/src/path.rs Outdated Show resolved Hide resolved
compiler/rustc_pattern_analysis/src/usefulness.rs Show resolved Hide resolved
compiler/rustc_query_system/src/dep_graph/dep_node.rs Show resolved Hide resolved
@fee1-dead
Copy link
Member

@bors rollup

@nnethercote
Copy link
Contributor Author

Thanks for the fast review! I have addressed the nits.

@bors r=fee1-dead

@bors
Copy link
Contributor

bors commented Apr 30, 2024

📌 Commit 2088de2 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
@bors
Auto merge of rust-lang#124558 - matthiaskrgr:rollup-axi1bxu, r=matth…
20aa2d8 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#123247 (Mention Both HRTB and Generic Lifetime Param in `E0637` documentation)
 - rust-lang#124511 (Remove many `#[macro_use] extern crate foo` items)
 - rust-lang#124550 (Remove redundant union check in `KnownPanicsLint` const prop)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 784316e into rust-lang:master Apr 30, 2024
9 checks passed
@rustbot rustbot added this to the 1.80.0 milestone Apr 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2024
@rust-timer
Unrolled build for rust-lang#124511
920ee69 
Rollup merge of rust-lang#124511 - nnethercote:rm-extern-crates, r=fee1-dead

Remove many `#[macro_use] extern crate foo` items

This requires the addition of more `use` items, which often make the code more verbose. But they also make the code easier to read, because `#[macro_use]` obscures where macros are defined.

r? `@fee1-dead`
@nnethercote nnethercote mentioned this pull request May 8, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#124914 - nnethercote:rm-extern-crate-rustc_…
a4839ea 
…middle, r=saethlin

Remove `#[macro_use] extern crate rustc middle` from numerous crates

Because explicit importing of macros via `use` items is nicer (more standard and readable) than implicit importing via `#[macro_use]`. This PR mops up some cases I didn't get to in rust-lang#124511.

r? `@saethlin`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 13, 2024
@bors
Auto merge of rust-lang#124914 - nnethercote:rm-extern-crate-rustc_mi…
ba956ef 
…ddle, r=saethlin

Remove `#[macro_use] extern crate rustc middle` from numerous crates

Because explicit importing of macros via `use` items is nicer (more standard and readable) than implicit importing via `#[macro_use]`. This PR mops up some cases I didn't get to in rust-lang#124511.

r? `@saethlin`
@fmease fmease mentioned this pull request May 13, 2024
Merged
@nnethercote nnethercote mentioned this pull request May 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2024
@bors
Auto merge of rust-lang#125434 - nnethercote:rm-more-extern-tracing, …
8679004 
…r=jackh726

Remove more `#[macro_use] extern crate tracing`

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via `#[macro_use]`. Continuing the work from rust-lang#124511 and rust-lang#124914.

r? `@jackh726`
@nnethercote nnethercote mentioned this pull request Aug 29, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 31, 2024
@workingjubilee
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracin…
b49ba78 
…g-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? `@jieyouxu`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracin…
0a7f781 
…g-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? ``@jieyouxu``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracin…
7d025bb 
…g-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? ```@jieyouxu```
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@rust-timer
Unrolled build for rust-lang#129767
4f0a0da 
Rollup merge of rust-lang#129767 - nnethercote:rm-extern-crate-tracing-4, r=jieyouxu

Remove `#[macro_use] extern crate tracing`, round 4

Because explicit importing of macros via use items is nicer (more standard and readable) than implicit importing via #[macro_use]. Continuing the work from rust-lang#124511, rust-lang#124914, and rust-lang#125434. After this PR no `rustc_*` crates use `#[macro_use] extern crate tracing` except for `rustc_codegen_gcc` which is a special case and I will do separately.

r? ```@jieyouxu```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rustbot @rust-log-analyzer @fee1-dead @bors