Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linker-plugin-lto.md to include LLVM 18 #125018

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented May 11, 2024

I did this manually not via provided script.

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2024
@GuillaumeGomez
Copy link
Member

r? Amanieu

@rustbot rustbot assigned Amanieu and unassigned GuillaumeGomez May 11, 2024
@Amanieu
Copy link
Member

Amanieu commented May 16, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 16, 2024

📌 Commit 1025b3f has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124871 (Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects)
 - rust-lang#125018 (Update linker-plugin-lto.md to include LLVM 18)
 - rust-lang#125130 (rustdoc-json-types: Document `Id`)
 - rust-lang#125170 (Uplift `FnSig` into `rustc_type_ir` (redux))
 - rust-lang#125172 (Fix assertion when attempting to convert `f16` and `f128` with `as`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 48f1019 into rust-lang:master May 16, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2024
Rollup merge of rust-lang#125018 - sagudev:patch-2, r=Amanieu

Update linker-plugin-lto.md to include LLVM 18

I did this manually not via provided script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants