Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: Implement windows::make_non_verbatim() #12596

Closed
wants to merge 2 commits into from

Conversation

lilyball
Copy link
Contributor

make_non_verbatim() takes a WindowsPath and returns a new one that does
not use the ?\ verbatim prefix, if possible.

Get rid of the unnecessary parenthesies that crept into some macros.
Remove a FIXME that was already fixed.
Fix a comment that wasn't rendering correctly in rustdoc.
make_non_verbatim() takes a WindowsPath and returns a new one that does
not use the \\?\ verbatim prefix, if possible.
@lilyball
Copy link
Contributor Author

cc @alexcrichton, this is what you asked for earlier today.

@bors bors closed this in 53e90c1 Feb 28, 2014
@lilyball lilyball deleted the make_non_verbatim branch March 25, 2014 02:25
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
fix: Don't trigger pattern completions when typing a wildcard pattern

Fixes rust-lang/rust-analyzer#12592
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 2, 2024
Modify lint pass note for consistency with the book

This PR:
- removes the note which appears when an early lint pass is created using `cargo dev new_lint`.
- adds a note that encourages contributors to use an early pass unless type information is needed if a late lint pass is created using `cargo dev new_lint`.

Late pass remains the default value if no pass is specified as most lints use late pass.

Closes rust-lang#12595

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants