Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap: Retry copying/linking #127147

Closed
wants to merge 1 commit into from
Closed

Bootstrap: Retry copying/linking #127147

wants to merge 1 commit into from

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jun 30, 2024 •
edited
Loading

May be a workaround for #127126. But it's hard to know if this works due to the error only appearing some times.

This just adds a retry loop with a fairly long pause between retries so as to give time to whatever is locking the file to give up its lock.

try-job: x86_64-msvc-ext

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2024

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 30, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ChrisDenton
Copy link
Member Author

Clippy insisting on code that doesn't compile was fun but I think I've figured out how to satisfy both the compiler and clippy.

I'll do a try build but chances are it'll succeed whether my PR helps or not.
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127147 - ChrisDenton:retry, r=<try>
0bdbe47 
Bootstrap: Retry copying/linking

May be a workaround for rust-lang#127126. But it's hard to know if this works due to the error only appearing some times.

This just adds a retry loop with a fairly long pause between retries so as to give time to whatever is locking the file to give up its lock.

try-job: x86_64-msvc-ext
@bors
Copy link
Contributor

bors commented Jun 30, 2024

⌛ Trying commit 1a19627 with merge 0bdbe47...

@bors
Copy link
Contributor

bors commented Jun 30, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ChrisDenton
Copy link
Member Author

Huh, that still failed. Hm.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ChrisDenton
Copy link
Member Author

Hm, I'll try a different approach.

@ChrisDenton ChrisDenton deleted the retry branch June 30, 2024 08:21
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@tgross35 tgross35 mentioned this pull request Oct 23, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@onur-ozkan onur-ozkan

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisDenton @rustbot @rust-log-analyzer @bors @onur-ozkan