doc: cleanups #12783
Merged
doc: cleanups #12783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -168,22 +161,24 @@ ifneq ($(ONLY_HTML_DOCS),1) | |||
| DOC_TARGETS += doc/$(1).epub | |||
| doc/$(1).epub: $$(D)/$(1).md | doc/ | |||
| @$$(call E, pandoc: $$@) | |||
| $$(Q)$$(CFG_NODE) $$(D)/prep.js --highlight $$< | \ | |||
There was a problem hiding this comment.
Does prep.js --highlight really have zero effect?
There was a problem hiding this comment.
Yes because prep.js outputs its own HTML directives which pandoc cannot recognize.
You can see it as the PDF doc has never been highlighted as of now.
Note that if we were to add the .rust class to snippets, we could probably use pandoc's native highlighting capatibilities i.e. Kate (here is an example of that).
There was a problem hiding this comment.
Could you put that specific information in the commit message and/or PR description so that someone looking at the gist history knows why this change happened?
`prep.js` outputs its own HTML directives, which `pandoc` cannot recognize when converting the document into LaTeX (this is why the PDF docs have never been highlighted as of now). Note that if we were to add the `.rust` class to snippets, we could probably use pandoc's native highlighting capatibilities i.e. Kate.
- fixup and refactor highlighting code - have a proper print stylesheet
|
Fixed. |
bors
added a commit
that referenced
this pull request
Mar 11, 2014
- remove `node.js` dep., it has no effect as of #12747 (1) - switch between LaTeX compilers, some cleanups - CSS: fixup the print stylesheet, refactor highlighting code (2) (1): `prep.js` outputs its own HTML directives, which `pandoc` cannot recognize when converting the document into LaTeX (this is why the PDF docs have never been highlighted as of now). Note that if we were to add the `.rust` class to snippets, we could probably use pandoc's native highlighting capatibilities i.e. Kate ([here is](http://adrientetar.github.io/rust-tuts/tutorial/tutorial.pdf) an example of that). (2): the only real highlighting change is for lifetimes which are now brown instead of red, the rest is just refactor of twos shades of red that look the same. Also I made numbers highlighting for src in rustdoc a tint more clear so that it is less bothering. @alexcrichton, @huonw Closes #9873. Closes #12788.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Add basic support for `augmentsSyntaxTokens` and non-standard semantic token config cc rust-lang#12783 Closes rust-lang/rust-analyzer#13066
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 17, 2024
…xyas fix: use hir_with_context to produce correct snippets for assigning_clones The `assigning_clones` lint is producing wrong output when the assignment is a macro call. Since Applicability level `Unspecified` will never be changed inside `hir_with_applicability`, so it is safe here to replace `hir_with_applicability` with `hir_with_context` to generate snippets of the macro call instead of the expansion. fixes rust-lang#12776 changelog: [`assigning_clones`]: use `hir_with_context` to produce correct snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.jsdep., it has no effect as of rustdoc: run on plain Markdown files & replace the use of pandoc for guides/tutorial/manual etc. #12747 (1)(1):
prep.jsoutputs its own HTML directives, whichpandoccannot recognize when converting the document into LaTeX (this is why the PDF docs have never been highlighted as of now).Note that if we were to add the
.rustclass to snippets, we could probably use pandoc's native highlighting capatibilities i.e. Kate (here is an example of that).(2): the only real highlighting change is for lifetimes which are now brown instead of red, the rest is just refactor of twos shades of red that look the same.
Also I made numbers highlighting for src in rustdoc a tint more clear so that it is less bothering.
@alexcrichton, @huonw
Closes #9873. Closes #12788.