-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate foreign-double-unwind
, issue-36710
and foreign-exceptions
run-make
tests to rmake
#127926
Conversation
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
c6a29da
to
14d5f2a
Compare
Question: should this be blocked on one of the |
This comment has been minimized.
This comment has been minimized.
14d5f2a
to
84b648c
Compare
Disregard the last CI fail, I just forgot to commit the fix. It should pass now.
As far as I am aware, the only other PR that modifies |
@bors try |
Migrate `foreign-double-unwind`, `issue-36710` and `foreign-exceptions` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~This is expected to fail CI, I am getting a weird `core dumped` error on `foreign-double-unwind` locally. Posting this to start a discussion.~~ EDIT: I got it, `foreign_double_unwind` is *supposed* to fail in the execution stage, but this wasn't obvious, because the original test was just piping the stdout to `CGREP` (which silently ignores errors). try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc try-job: x86_64-gnu-llvm-18 try-job: i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #128169) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors delegate+ (for try job) |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
This comment was marked as resolved.
This comment was marked as resolved.
@rustbot review (double check CXX_DEFAULT_FLAGS in compiletest, somehow we're passing |
b89be60
to
d4345e9
Compare
Migrate `foreign-double-unwind`, `issue-36710` and `foreign-exceptions` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). ~~This is expected to fail CI, I am getting a weird `core dumped` error on `foreign-double-unwind` locally. Posting this to start a discussion.~~ EDIT: I got it, `foreign_double_unwind` is *supposed* to fail in the execution stage, but this wasn't obvious, because the original test was just piping the stdout to `CGREP` (which silently ignores errors). try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc try-job: x86_64-gnu-llvm-18 try-job: i686-msvc try-job: dist-i586-gnu-i586-i686-musl
☀️ Try build successful - checks-actions |
0e9fa9b
to
70750dc
Compare
@rustbot review |
☔ The latest upstream changes (presumably #127624) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me with a rebase
@bors delegate+ |
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
@bors rollup=iffy (foreign unwinding, native c/c++ libs, exceptions) |
70750dc
to
46b4083
Compare
☀️ Test successful - checks-actions |
Finished benchmarking commit (f82eb4d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 3.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 759.288s -> 757.978s (-0.17%) |
Part of #121876 and the associated Google Summer of Code project.
This is expected to fail CI, I am getting a weirdcore dumped
error onforeign-double-unwind
locally. Posting this to start a discussion.EDIT: I got it,
foreign_double_unwind
is supposed to fail in the execution stage, but this wasn't obvious, because the original test was just piping the stdout toCGREP
(which silently ignores errors).try-job: aarch64-apple
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc
try-job: x86_64-gnu-llvm-18
try-job: i686-msvc
try-job: dist-i586-gnu-i586-i686-musl