Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate cross-lang-lto run-make test to rmake #128352

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Migrate cross-lang-lto run-make test to rmake #128352

merged 1 commit into from
Aug 2, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 29, 2024 •
edited by jieyouxu
Loading

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
try-job: x86_64-mingw
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

@jieyouxu
Copy link
Member

@bors try

@jieyouxu jieyouxu mentioned this pull request Jul 29, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2024
@bors
Auto merge of rust-lang#128352 - Oneirical:daLTOnist-vision, r=<try>
39dbcbf 
Migrate `cross-lang-lto` `run-make` test to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
@bors
Copy link
Contributor

bors commented Jul 29, 2024

⌛ Trying commit c8455d2 with merge 39dbcbf...

@bors
Copy link
Contributor

bors commented Jul 29, 2024

☀️ Try build successful - checks-actions
Build commit: 39dbcbf (39dbcbf020cbc8f63e3893ed3c68492b77f0801f)

jieyouxu
jieyouxu approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look good, just some minor nits.

tests/run-make/cross-lang-lto/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/cross-lang-lto/rmake.rs Show resolved Hide resolved
tests/run-make/cross-lang-lto/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/cross-lang-lto/rmake.rs Outdated Show resolved Hide resolved
@jieyouxu
Copy link
Member

@bors try

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024
@bors
Auto merge of rust-lang#128352 - Oneirical:daLTOnist-vision, r=<try>
6cb855d 
Migrate `cross-lang-lto` `run-make` test to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
try-job: x86_64-mingw
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18
@bors
Copy link
Contributor

bors commented Jul 30, 2024

⌛ Trying commit c8455d2 with merge 6cb855d...

@Oneirical
Copy link
Contributor Author

All changes applied.

Sorry, I didn't see you started a try-job, not sure if my push cancelled it.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2024
@jieyouxu
Copy link
Member

All changes applied.

Sorry, I didn't see you started a try-job, not sure if my push cancelled it.

No it's fine, AFAIK the try job will continue on the commit I started it on (only cosmetic changes, so no worries).

jieyouxu
jieyouxu approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

@jieyouxu
Copy link
Member

The try job actually succeeded, it just didn't post a message.

@bors r+ rollup=iffy (cross language LTO)

@bors
Copy link
Contributor

bors commented Jul 30, 2024

📌 Commit fbd930b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024
@bors
Copy link
Contributor

bors commented Jul 31, 2024

☔ The latest upstream changes (presumably #128075) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2024
@jieyouxu
Copy link
Member

r=me with a rebase

@bors delegate+

@bors
Copy link
Contributor

bors commented Jul 31, 2024

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@Oneirical
Copy link
Contributor Author

@bors r=@jieyouxu

@bors
Copy link
Contributor

bors commented Jul 31, 2024

📌 Commit b652b3a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical
Copy link
Contributor Author

Oneirical commented Jul 31, 2024 •
edited
Loading

@bors r- (I deleted an extra line during the rebase)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2024
@Oneirical
Copy link
Contributor Author

@bors r=@jieyouxu

@bors
Copy link
Contributor

bors commented Jul 31, 2024

📌 Commit 152db27 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 1, 2024
@tgross35
Rollup merge of rust-lang#128352 - Oneirical:daLTOnist-vision, r=jiey…
2144408 
…ouxu

Migrate `cross-lang-lto` `run-make` test to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
try-job: x86_64-mingw
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18
@tgross35 tgross35 mentioned this pull request Aug 1, 2024
Closed
@bors
Copy link
Contributor

bors commented Aug 2, 2024

⌛ Testing commit 152db27 with merge 5367673...

@bors
Copy link
Contributor

bors commented Aug 2, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 5367673 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2024
@bors bors merged commit 5367673 into rust-lang:master Aug 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 2, 2024
@bors bors mentioned this pull request Aug 2, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5367673): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.218s -> 759.288s (0.54%)
Artifact size: 336.77 MiB -> 336.86 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Oneirical @rustbot @jieyouxu @bors @rust-log-analyzer @rust-timer