Point at explicit `'static` obligations on a trait #129070

estebank · 2024-08-14T00:15:28Z

Given trait Any: 'static and a struct with a Box<dyn Any + 'a> field, point at the 'static bound in Any to explain why 'a: 'static.

error[E0478]: lifetime bound not satisfied
   --> f202.rs:2:12
    |
2   |     value: Box<dyn std::any::Any + 'a>,
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: lifetime parameter instantiated with the lifetime `'a` as defined here
   --> f202.rs:1:14
    |
1   | struct Hello<'a> {
    |              ^^
note: but lifetime parameter must outlive the static lifetime
   --> /home/gh-estebank/rust/library/core/src/any.rs:113:16
    |
113 | pub trait Any: 'static {
    |                ^^^^^^^

Partially address #33652.

rustbot · 2024-08-14T00:15:36Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

estebank · 2024-08-14T00:18:19Z

tests/ui/regions/explicit-static-bound-on-trait.stderr

+note: but lifetime parameter must outlive the static lifetime
+  --> $SRC_DIR/core/src/any.rs:LL:COL


Locally this actually show the right span, not sure why the stderr doesn't show it correctly.

~~Probably has to do with the sorting of the entries. Try to put the Option<Ty> first?~~

Oh, no, because we strip standard library sources in UI tests.

estebank · 2024-08-14T00:18:58Z

tests/ui/regions/explicit-static-bound-on-trait.stderr

+error[E0310]: the parameter type `T` may not live long enough
+  --> $DIR/explicit-static-bound-on-trait.rs:8:23
+   |
+LL |         Self { value: Box::new(value) }
+   |                       ^^^^^^^^^^^^^^^
+   |                       |
+   |                       the parameter type `T` must be valid for the static lifetime...
+   |                       ...so that the type `T` will meet its required lifetime bounds
+   |
+help: consider adding an explicit lifetime bound
+   |
+LL |     fn new<T: 'a + 'static>(value: T) -> Self {
+   |                  +++++++++


This is the actual error that we should add context for in order to also support traits that are implicitly 'static because of the trait.

davidtwco

LGTM, r=me unless you want to experiment with compiler-errors' suggestions or your other comment isn't just something you intend to follow-up with.

compiler/rustc_trait_selection/src/error_reporting/infer/note.rs

Given `trait Any: 'static` and a `struct` with a `Box<dyn Any + 'a>` field, point at the `'static` bound in `Any` to explain why `'a: 'static`. ``` error[E0478]: lifetime bound not satisfied --> f202.rs:2:12 | 2 | value: Box<dyn std::any::Any + 'a>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: lifetime parameter instantiated with the lifetime `'a` as defined here --> f202.rs:1:14 | 1 | struct Hello<'a> { | ^^ note: but lifetime parameter must outlive the static lifetime --> /home/gh-estebank/rust/library/core/src/any.rs:113:16 | 113 | pub trait Any: 'static { | ^^^^^^^ ``` Partially address rust-lang#33652.

estebank · 2024-08-21T17:02:09Z

@bors r=davidtwco

bors · 2024-08-21T17:02:11Z

📌 Commit f5bae72 has been approved by davidtwco

It is now in the queue for this repository.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127279 (use old ctx if has same expand environment during decode span) - rust-lang#127945 (Implement `debug_more_non_exhaustive`) - rust-lang#128941 ( Improve diagnostic-related lints: `untranslatable_diagnostic` & `diagnostic_outside_of_impl`) - rust-lang#129070 (Point at explicit `'static` obligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129231 (improve submodule updates) - rust-lang#129264 (Update `library/Cargo.toml` in weekly job) - rust-lang#129284 (rustdoc: animate the `:target` highlight) - rust-lang#129302 (compiletest: use `std::fs::remove_dir_all` now that it is available) r? `@ghost` `@rustbot` modify labels: rollup

Point at explicit `'static` obligations on a trait Given `trait Any: 'static` and a `struct` with a `Box<dyn Any + 'a>` field, point at the `'static` bound in `Any` to explain why `'a: 'static`. ``` error[E0478]: lifetime bound not satisfied --> f202.rs:2:12 | 2 | value: Box<dyn std::any::Any + 'a>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: lifetime parameter instantiated with the lifetime `'a` as defined here --> f202.rs:1:14 | 1 | struct Hello<'a> { | ^^ note: but lifetime parameter must outlive the static lifetime --> /home/gh-estebank/rust/library/core/src/any.rs:113:16 | 113 | pub trait Any: 'static { | ^^^^^^^ ``` Partially address rust-lang#33652.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127279 (use old ctx if has same expand environment during decode span) - rust-lang#127945 (Implement `debug_more_non_exhaustive`) - rust-lang#128941 ( Improve diagnostic-related lints: `untranslatable_diagnostic` & `diagnostic_outside_of_impl`) - rust-lang#129070 (Point at explicit `'static` obligations on a trait) - rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation) - rust-lang#129231 (improve submodule updates) - rust-lang#129264 (Update `library/Cargo.toml` in weekly job) - rust-lang#129284 (rustdoc: animate the `:target` highlight) - rust-lang#129302 (compiletest: use `std::fs::remove_dir_all` now that it is available) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129070 - estebank:static-trait, r=davidtwco Point at explicit `'static` obligations on a trait Given `trait Any: 'static` and a `struct` with a `Box<dyn Any + 'a>` field, point at the `'static` bound in `Any` to explain why `'a: 'static`. ``` error[E0478]: lifetime bound not satisfied --> f202.rs:2:12 | 2 | value: Box<dyn std::any::Any + 'a>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: lifetime parameter instantiated with the lifetime `'a` as defined here --> f202.rs:1:14 | 1 | struct Hello<'a> { | ^^ note: but lifetime parameter must outlive the static lifetime --> /home/gh-estebank/rust/library/core/src/any.rs:113:16 | 113 | pub trait Any: 'static { | ^^^^^^^ ``` Partially address rust-lang#33652.

rustbot assigned davidtwco Aug 14, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2024

estebank commented Aug 14, 2024

View reviewed changes

davidtwco approved these changes Aug 21, 2024

View reviewed changes

compiler-errors reviewed Aug 21, 2024

View reviewed changes

compiler/rustc_trait_selection/src/error_reporting/infer/note.rs Outdated Show resolved Hide resolved

estebank force-pushed the static-trait branch from 73da462 to f5bae72 Compare August 21, 2024 16:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024

matthiaskrgr mentioned this pull request Aug 21, 2024

Rollup of 9 pull requests #129365

Merged

jieyouxu mentioned this pull request Aug 22, 2024

Rollup of 8 pull requests #129393

Closed

bors merged commit ffdbd9d into rust-lang:master Aug 22, 2024
6 checks passed

rustbot added this to the 1.82.0 milestone Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Point at explicit `'static` obligations on a trait #129070

Point at explicit `'static` obligations on a trait #129070

estebank commented Aug 14, 2024

rustbot commented Aug 14, 2024

estebank Aug 14, 2024

compiler-errors Aug 14, 2024 •

edited

Loading

compiler-errors Aug 21, 2024

estebank Aug 14, 2024

davidtwco left a comment

estebank commented Aug 21, 2024

bors commented Aug 21, 2024

		note: but lifetime parameter must outlive the static lifetime
		--> $SRC_DIR/core/src/any.rs:LL:COL

Point at explicit 'static obligations on a trait #129070

Point at explicit 'static obligations on a trait #129070

Conversation

estebank commented Aug 14, 2024

rustbot commented Aug 14, 2024

estebank Aug 14, 2024

Choose a reason for hiding this comment

compiler-errors Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

compiler-errors Aug 21, 2024

Choose a reason for hiding this comment

estebank Aug 14, 2024

Choose a reason for hiding this comment

davidtwco left a comment

Choose a reason for hiding this comment

estebank commented Aug 21, 2024

bors commented Aug 21, 2024

Point at explicit `'static` obligations on a trait #129070

Point at explicit `'static` obligations on a trait #129070

compiler-errors Aug 14, 2024 •

edited

Loading