Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver #129678

compiler-errors · 2024-08-28T04:17:40Z

We shouldn't encourage using rustc_type_ir::inherent outside of the new solver¹, though this can happen by accident due to rust-analyzer, for example. See #127537 (comment) for an example in practice.

r? fmease

Unless we go the fully radical approach of always using these inherent methods everywhere in favor of inherent methods, which would be a major overhaul of the compiler, IMO. I don't really want to consider that possibility right now, tho. ↩

fmease · 2024-08-28T04:43:21Z

r=me after trivial pub→pub(crate) fix
@bors rollup

compiler/rustc_next_trait_solver/src/lib.rs

compiler-errors · 2024-08-29T15:24:16Z

@bors r=fmease rollup

bors · 2024-08-29T15:24:19Z

📌 Commit 0064d81 has been approved by fmease

It is now in the queue for this repository.

bors · 2024-08-30T00:08:09Z

☔ The latest upstream changes (presumably #129750) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2024-08-30T12:04:42Z

@bors r=fmease

bors · 2024-08-30T12:04:45Z

📌 Commit 1447e9c has been approved by fmease

It is now in the queue for this repository.

…r=fmease Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver We shouldn't encourage using `rustc_type_ir::inherent` outside of the new solver[^1], though this can happen by accident due to rust-analyzer, for example. See rust-lang#127537 (comment) for an example in practice. r? fmease [^1]: Unless we go the fully radical approach of always using these inherent methods everywhere in favor of inherent methods, which would be a major overhaul of the compiler, IMO. I don't really want to consider that possibility right now, tho.

…kingjubilee Rollup of 16 pull requests Successful merges: - rust-lang#129123 (rustdoc-json: Add test for `Self` type) - rust-lang#129675 (allow BufReader::peek to be called on unsized types) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129723 (Simplify some extern providers) - rust-lang#129724 (Remove `Option<!>` return types.) - rust-lang#129725 (Stop using `ty::GenericPredicates` for non-predicates_of queries) - rust-lang#129730 (f32 docs: define 'arithmetic' operations) - rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection) - rust-lang#129760 (Make the "detect-old-time" UI test more representative) - rust-lang#129762 (Update the `wasm-component-ld` binary dependency) - rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4) - rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt) - rust-lang#129780 (add crashtests for several old unfixed ICEs) - rust-lang#129782 (couple more crash tests) - rust-lang#129791 (mark joboet as on vacation) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2024-08-31T07:03:29Z

Seems to have failed in #129802 (comment)

warning: unknown lint: rustc::usage_of_type_ir_inherent

@bors r-

fmease · 2024-08-31T08:04:53Z

Ah yes, the test needs to //@ ignore-stage1 just like in #127854 (can be removed after the next beta bump at the earliest)

…t solver

compiler-errors · 2024-09-01T16:17:05Z

@bors r=fmease

bors · 2024-09-01T16:17:08Z

📌 Commit 9185445 has been approved by fmease

It is now in the queue for this repository.

…r=fmease Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver We shouldn't encourage using `rustc_type_ir::inherent` outside of the new solver[^1], though this can happen by accident due to rust-analyzer, for example. See rust-lang#127537 (comment) for an example in practice. r? fmease [^1]: Unless we go the fully radical approach of always using these inherent methods everywhere in favor of inherent methods, which would be a major overhaul of the compiler, IMO. I don't really want to consider that possibility right now, tho.

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

…r=fmease Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver We shouldn't encourage using `rustc_type_ir::inherent` outside of the new solver[^1], though this can happen by accident due to rust-analyzer, for example. See rust-lang#127537 (comment) for an example in practice. r? fmease [^1]: Unless we go the fully radical approach of always using these inherent methods everywhere in favor of inherent methods, which would be a major overhaul of the compiler, IMO. I don't really want to consider that possibility right now, tho.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#127021 (Add target support for RTEMS Arm) - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129678 - compiler-errors:type-ir-inherent, r=fmease Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver We shouldn't encourage using `rustc_type_ir::inherent` outside of the new solver[^1], though this can happen by accident due to rust-analyzer, for example. See rust-lang#127537 (comment) for an example in practice. r? fmease [^1]: Unless we go the fully radical approach of always using these inherent methods everywhere in favor of inherent methods, which would be a major overhaul of the compiler, IMO. I don't really want to consider that possibility right now, tho.

rustbot assigned fmease Aug 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 28, 2024

This comment has been minimized.

Sign in to view

fmease approved these changes Aug 28, 2024

View reviewed changes

fmease reviewed Aug 28, 2024

View reviewed changes

compiler/rustc_next_trait_solver/src/lib.rs Show resolved Hide resolved

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2024

compiler-errors force-pushed the type-ir-inherent branch from f2cb7cc to 0064d81 Compare August 29, 2024 15:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2024

compiler-errors force-pushed the type-ir-inherent branch from 0064d81 to 1447e9c Compare August 30, 2024 12:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2024

workingjubilee mentioned this pull request Aug 31, 2024

Rollup of 16 pull requests #129802

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2024

Deny imports of rustc_type_ir::inherent outside of type ir + new trai…

9185445

…t solver

compiler-errors force-pushed the type-ir-inherent branch from 1447e9c to 9185445 Compare September 1, 2024 16:16

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2024

GuillaumeGomez mentioned this pull request Sep 1, 2024

Rollup of 7 pull requests #129862

Closed

matthiaskrgr mentioned this pull request Sep 2, 2024

Rollup of 9 pull requests #129873

Merged

workingjubilee mentioned this pull request Sep 2, 2024

Rollup of 11 pull requests #129879

Closed

bors merged commit e003917 into rust-lang:master Sep 2, 2024
6 checks passed

rustbot added this to the 1.83.0 milestone Sep 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver #129678

Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver #129678

compiler-errors commented Aug 28, 2024

This comment has been minimized.

fmease commented Aug 28, 2024 •

edited

Loading

compiler-errors commented Aug 29, 2024

bors commented Aug 29, 2024

bors commented Aug 30, 2024

compiler-errors commented Aug 30, 2024

bors commented Aug 30, 2024

workingjubilee commented Aug 31, 2024

fmease commented Aug 31, 2024 •

edited

Loading

compiler-errors commented Sep 1, 2024

bors commented Sep 1, 2024

Deny imports of rustc_type_ir::inherent outside of type ir + new trait solver #129678

Deny imports of rustc_type_ir::inherent outside of type ir + new trait solver #129678

Conversation

compiler-errors commented Aug 28, 2024

Footnotes

This comment has been minimized.

fmease commented Aug 28, 2024 • edited Loading

compiler-errors commented Aug 29, 2024

bors commented Aug 29, 2024

bors commented Aug 30, 2024

compiler-errors commented Aug 30, 2024

bors commented Aug 30, 2024

workingjubilee commented Aug 31, 2024

fmease commented Aug 31, 2024 • edited Loading

compiler-errors commented Sep 1, 2024

bors commented Sep 1, 2024

Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver #129678

Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver #129678

fmease commented Aug 28, 2024 •

edited

Loading

fmease commented Aug 31, 2024 •

edited

Loading