Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 9) #130287

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 12, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Sep 12, 2024
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 12, 2024

📌 Commit 48c7e44 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2024
Rollup of 3 pull requests

Successful merges:

 - rust-lang#130245 (make basic allocation functions track_caller in Miri for nicer backtraces)
 - rust-lang#130261 (skip target sanity check when it's a `local-rebuild`)
 - rust-lang#130287 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1c23c8b into rust-lang:master Sep 13, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2024
Rollup merge of rust-lang#130287 - notriddle:notriddle/issue-d, r=jieyouxu

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382
* rust-lang#127671

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@rustbot rustbot added this to the 1.83.0 milestone Sep 13, 2024
@notriddle notriddle deleted the notriddle/issue-d branch September 13, 2024 13:54
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 9, 2024
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 9, 2024
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 9, 2024
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
fmease added a commit to fmease/rust that referenced this pull request Dec 9, 2024
…llaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
Rollup merge of rust-lang#134053 - notriddle:notriddle/issue-d, r=GuillaumeGomez

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 11, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 10)

Follow up rust-lang/rust#130287 et al

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants